You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/12/13 15:29:07 UTC

[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1445: IGNITE-18399 Adapt WorkDirectoryExtension to Gradle

SammyVimes commented on code in PR #1445:
URL: https://github.com/apache/ignite-3/pull/1445#discussion_r1047315040


##########
modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/WorkDirectoryExtension.java:
##########
@@ -270,4 +270,15 @@ private static boolean isEmpty(Path dir) throws IOException {
         }
     }
 
+    private static Path getBasePath() {
+        // Maven build folder
+        Path mavenPath = Path.of("target");

Review Comment:
   Do you think we need maven?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org