You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2020/07/30 09:27:07 UTC
[GitHub] [cxf] amarkevich opened a new pull request #687: Update to hsqldb 2.5.1
amarkevich opened a new pull request #687:
URL: https://github.com/apache/cxf/pull/687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] amarkevich merged pull request #687: Update to hsqldb 2.5.1
Posted by GitBox <gi...@apache.org>.
amarkevich merged pull request #687:
URL: https://github.com/apache/cxf/pull/687
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] amarkevich commented on a change in pull request #687: Update to hsqldb 2.5.1
Posted by GitBox <gi...@apache.org>.
amarkevich commented on a change in pull request #687:
URL: https://github.com/apache/cxf/pull/687#discussion_r469706412
##########
File path: rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcUserSubject.java
##########
@@ -54,6 +55,7 @@ public OidcUserSubject(UserSubject sub) {
@Lob
@Basic(fetch = FetchType.EAGER)
+ @Column(length = 1024)
Review comment:
updated @Column annotation: explicit 'blob' column type without length
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] amarkevich commented on a change in pull request #687: Update to hsqldb 2.5.1
Posted by GitBox <gi...@apache.org>.
amarkevich commented on a change in pull request #687:
URL: https://github.com/apache/cxf/pull/687#discussion_r468840905
##########
File path: rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcUserSubject.java
##########
@@ -54,6 +55,7 @@ public OidcUserSubject(UserSubject sub) {
@Lob
@Basic(fetch = FetchType.EAGER)
+ @Column(length = 1024)
Review comment:
Looks like recent Hibernate cause [1]:
> creates column as CLOB(255)
So I set some higher value.
1. https://stackoverflow.com/a/26805926/3476615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] coheigea commented on a change in pull request #687: Update to hsqldb 2.5.1
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #687:
URL: https://github.com/apache/cxf/pull/687#discussion_r469059896
##########
File path: rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcUserSubject.java
##########
@@ -54,6 +55,7 @@ public OidcUserSubject(UserSubject sub) {
@Lob
@Basic(fetch = FetchType.EAGER)
+ @Column(length = 1024)
Review comment:
I'm wondering if a JWT token can be longer than 1024 characters....say if it has a lot of claims?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] coheigea commented on a change in pull request #687: Update to hsqldb 2.5.1
Posted by GitBox <gi...@apache.org>.
coheigea commented on a change in pull request #687:
URL: https://github.com/apache/cxf/pull/687#discussion_r467774651
##########
File path: rt/rs/security/sso/oidc/src/main/java/org/apache/cxf/rs/security/oidc/idp/OidcUserSubject.java
##########
@@ -54,6 +55,7 @@ public OidcUserSubject(UserSubject sub) {
@Lob
@Basic(fetch = FetchType.EAGER)
+ @Column(length = 1024)
Review comment:
Where does 1024 come from?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org