You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/18 10:18:37 UTC

[GitHub] [flink] JingsongLi commented on a change in pull request #9153: [FLINK-13315][table-api] Port wmstrategies to api-java-bridge

JingsongLi commented on a change in pull request #9153: [FLINK-13315][table-api] Port wmstrategies to api-java-bridge
URL: https://github.com/apache/flink/pull/9153#discussion_r304842548
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/stream/StreamExecTableSourceScan.scala
 ##########
 @@ -173,7 +176,8 @@ class StreamExecTableSourceScan(
           val watermarkGenerator = new PeriodicWatermarkAssignerWrapper(rowtimeFieldIdx, p)
           ingestedTable.assignTimestampsAndWatermarks(watermarkGenerator)
         case p: PunctuatedWatermarkAssigner =>
-          val watermarkGenerator = new PunctuatedWatermarkAssignerWrapper(rowtimeFieldIdx, p)
+          val watermarkGenerator =
+            new PunctuatedWatermarkAssignerWrapper(rowtimeFieldIdx, p, producedDataType)
 
 Review comment:
   No, in this case, I want to keep user type information to an original Row. (Like a pojo field in Row)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services