You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/16 09:36:03 UTC
[GitHub] [rocketmq-clients] guyinyou opened a new pull request, #155: fix bug in changeInvisibleDuration
guyinyou opened a new pull request, #155:
URL: https://github.com/apache/rocketmq-clients/pull/155
fix bug in changeInvisibleDuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] codecov-commenter commented on pull request #155: fix bug in changeInvisibleDuration
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #155:
URL: https://github.com/apache/rocketmq-clients/pull/155#issuecomment-1217362625
# [Codecov](https://codecov.io/gh/apache/rocketmq-clients/pull/155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#155](https://codecov.io/gh/apache/rocketmq-clients/pull/155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fef82e3) into [master](https://codecov.io/gh/apache/rocketmq-clients/commit/cf00205687d38d0de9fe5e22f76433f6c061c9e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cf00205) will **decrease** coverage by `2.64%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #155 +/- ##
============================================
- Coverage 30.68% 28.04% -2.65%
- Complexity 550 552 +2
============================================
Files 189 189
Lines 8612 8612
Branches 283 283
============================================
- Hits 2643 2415 -228
- Misses 5830 6056 +226
- Partials 139 141 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| java | `52.19% <0.00%> (+0.18%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-clients/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cketmq/client/java/impl/consumer/ConsumerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvY29uc3VtZXIvQ29uc3VtZXJJbXBsLmphdmE=) | `74.79% <0.00%> (ø)` | |
| [cpp/source/client/TlsHelper.cpp](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NvdXJjZS9jbGllbnQvVGxzSGVscGVyLmNwcA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [cpp/source/client/include/RpcClient.h](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NvdXJjZS9jbGllbnQvaW5jbHVkZS9ScGNDbGllbnQuaA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [cpp/source/client/include/ClientManager.h](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NvdXJjZS9jbGllbnQvaW5jbHVkZS9DbGllbnRNYW5hZ2VyLmg=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [cpp/source/client/TopicAssignmentInfo.cpp](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NvdXJjZS9jbGllbnQvVG9waWNBc3NpZ25tZW50SW5mby5jcHA=) | `0.00% <0.00%> (-70.00%)` | :arrow_down: |
| [cpp/source/client/include/TopicAssignmentInfo.h](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NvdXJjZS9jbGllbnQvaW5jbHVkZS9Ub3BpY0Fzc2lnbm1lbnRJbmZvLmg=) | `0.00% <0.00%> (-60.00%)` | :arrow_down: |
| [cpp/source/client/ClientManagerImpl.cpp](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NvdXJjZS9jbGllbnQvQ2xpZW50TWFuYWdlckltcGwuY3Bw) | `0.00% <0.00%> (-21.47%)` | :arrow_down: |
| [cpp/source/base/Protocol.cpp](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NvdXJjZS9iYXNlL1Byb3RvY29sLmNwcA==) | `0.00% <0.00%> (-19.49%)` | :arrow_down: |
| [...cketmq/client/java/impl/producer/ProducerImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvcHJvZHVjZXIvUHJvZHVjZXJJbXBsLmphdmE=) | `31.46% <0.00%> (-1.13%)` | :arrow_down: |
| [...g/apache/rocketmq/client/java/impl/ClientImpl.java](https://codecov.io/gh/apache/rocketmq-clients/pull/155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-amF2YS9jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL2NsaWVudC9qYXZhL2ltcGwvQ2xpZW50SW1wbC5qYXZh) | `36.00% <0.00%> (+3.07%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] guyinyou commented on pull request #155: fix bug in changeInvisibleDuration
Posted by GitBox <gi...@apache.org>.
guyinyou commented on PR #155:
URL: https://github.com/apache/rocketmq-clients/pull/155#issuecomment-1217361790
> Nice catch! It would better if the checkstyle issue is addressed.
i will
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-clients] aaron-ai merged pull request #155: fix bug in changeInvisibleDuration
Posted by GitBox <gi...@apache.org>.
aaron-ai merged PR #155:
URL: https://github.com/apache/rocketmq-clients/pull/155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org