You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/15 14:02:39 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #5006: net/tcp: fix send deadlock if disconnect
anchao opened a new pull request #5006:
URL: https://github.com/apache/incubator-nuttx/pull/5006
## Summary
net/tcp: fix send deadlock if disconnect
## Impact
tcp send buffer mode
## Testing
iperf test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5006: net/tcp: fix send deadlock if disconnect
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5006:
URL: https://github.com/apache/incubator-nuttx/pull/5006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5006: net/tcp: fix send deadlock if disconnect
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5006:
URL: https://github.com/apache/incubator-nuttx/pull/5006#discussion_r769670134
##########
File path: net/tcp/tcp_send_buffered.c
##########
@@ -1040,7 +1040,7 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,
goto errout;
}
- if (psock->s_type != SOCK_STREAM || !_SS_ISCONNECTED(psock->s_flags))
Review comment:
Why `!_SS_ISCONNECTED(psock->s_flags)` is removed from condition here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5006: net/tcp: fix send deadlock if disconnect
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #5006:
URL: https://github.com/apache/incubator-nuttx/pull/5006#discussion_r769680318
##########
File path: net/tcp/tcp_send_buffered.c
##########
@@ -1040,7 +1040,7 @@ ssize_t psock_tcp_send(FAR struct socket *psock, FAR const void *buf,
goto errout;
}
- if (psock->s_type != SOCK_STREAM || !_SS_ISCONNECTED(psock->s_flags))
Review comment:
just reference unbuffer send mode, let us keep check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org