You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/12/21 13:41:57 UTC
[GitHub] [ignite] nizhikov opened a new pull request #9678: IGNITE-13359 .NET: GetServiceDescriptor implemented
nizhikov opened a new pull request #9678:
URL: https://github.com/apache/ignite/pull/9678
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov merged pull request #9678: IGNITE-13359 .NET: Add GetServiceDescriptor
Posted by GitBox <gi...@apache.org>.
nizhikov merged pull request #9678:
URL: https://github.com/apache/ignite/pull/9678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9678: IGNITE-13359 .NET: GetServiceDescriptor implemented
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #9678:
URL: https://github.com/apache/ignite/pull/9678#discussion_r773212603
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Services/IServicesClient.cs
##########
@@ -38,6 +40,19 @@ public interface IServicesClient
/// <returns>Proxy object that forwards all member calls to a remote Ignite service.</returns>
T GetServiceProxy<T>(string serviceName) where T : class;
+ /// <summary>
+ /// Gets metadata about all deployed services in the grid.
+ /// </summary>
+ /// <returns>Metadata about all deployed services in the grid.</returns>
+ ICollection<IClientServiceDescriptor> ServiceDescriptors();
Review comment:
```suggestion
ICollection<IClientServiceDescriptor> GetServiceDescriptors();
```
(to be consistent with `IServices` and .NET naming guidelines)
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Services/IServicesClient.cs
##########
@@ -38,6 +40,19 @@ public interface IServicesClient
/// <returns>Proxy object that forwards all member calls to a remote Ignite service.</returns>
T GetServiceProxy<T>(string serviceName) where T : class;
+ /// <summary>
+ /// Gets metadata about all deployed services in the grid.
+ /// </summary>
+ /// <returns>Metadata about all deployed services in the grid.</returns>
+ ICollection<IClientServiceDescriptor> ServiceDescriptors();
+
+ /// <summary>
+ /// Gets metadata about deployed services in the grid.
+ /// </summary>
+ /// <param name="serviceName">Service name</param>
+ /// <returns>Metadata about all deployed services in the grid.</returns>
+ IClientServiceDescriptor ServiceDescriptor(string serviceName);
Review comment:
```suggestion
IClientServiceDescriptor GetServiceDescriptor(string serviceName);
```
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Services/IClientServiceDescriptor.cs
##########
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Client.Services
+{
+ using System;
+
+ /// <summary>
+ /// Descriptor of Service.
+ /// </summary>
+ public interface IClientServiceDescriptor
+ {
+ /// <summary>
+ /// Gets service name.
+ /// </summary>
+ /// <returns>Service name.</returns>
+ string Name { get; }
+
+ /// <summary>
+ /// Gets service class name.
+ /// </summary>
+ /// <returns>Service class name.</returns>
+ string ServiceClass { get; }
+
+ /// <summary>
+ /// Gets maximum allowed total number of deployed services in the grid, 0 for unlimited.
+ /// </summary>
+ /// <returns>Maximum allowed total number of deployed services in the grid, 0 for unlimited.</returns>
+ int TotalCount { get; }
+
+ /// <summary>
+ /// Gets maximum allowed number of deployed services on each node, {@code 0} for unlimited.
+ /// </summary>
+ /// <returns>Maximum allowed total number of deployed services on each node, {@code 0} for unlimited.</returns>
+ int MaxPerNodeCount { get; }
+
+ /// <summary>
+ /// Gets cache name used for key-to-node affinity calculation.
+ /// This parameter is optional and is set only when key-affinity service was deployed.
+ /// </summary>
+ /// <returns>Cache name, possibly null.</returns>
+ string CacheName { get; }
+
+ /// <summary>
+ /// Gets ID of grid node that initiated the service deployment.
+ /// </summary>
+ /// <returns>ID of grid node that initiated the service deployment.</returns>
+ Guid? OriginNodeId { get; }
+
+ /// <summary>
+ /// Platform id.
+ /// <ul>
+ /// <li>0 is Java platform service.</li>
+ /// <li>1 is .Net platform service.</li>
+ /// </ul>
+ /// </summary>
+ /// <returns>Platform id.</returns>
+ byte PlatformId { get; }
Review comment:
Same as #9677 , let's add an `enum PlatformType` to the public API. In case of .NET we can move internal `Apache.Ignite.Core.Impl.Common.PlatformType` to `Apache.Ignite.Core.Common.PlatformType` and make it public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] nizhikov commented on a change in pull request #9678: IGNITE-13359 .NET: GetServiceDescriptor implemented
Posted by GitBox <gi...@apache.org>.
nizhikov commented on a change in pull request #9678:
URL: https://github.com/apache/ignite/pull/9678#discussion_r773259113
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Services/IServicesClient.cs
##########
@@ -38,6 +40,19 @@ public interface IServicesClient
/// <returns>Proxy object that forwards all member calls to a remote Ignite service.</returns>
T GetServiceProxy<T>(string serviceName) where T : class;
+ /// <summary>
+ /// Gets metadata about all deployed services in the grid.
+ /// </summary>
+ /// <returns>Metadata about all deployed services in the grid.</returns>
+ ICollection<IClientServiceDescriptor> ServiceDescriptors();
Review comment:
Fixed
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Services/IServicesClient.cs
##########
@@ -38,6 +40,19 @@ public interface IServicesClient
/// <returns>Proxy object that forwards all member calls to a remote Ignite service.</returns>
T GetServiceProxy<T>(string serviceName) where T : class;
+ /// <summary>
+ /// Gets metadata about all deployed services in the grid.
+ /// </summary>
+ /// <returns>Metadata about all deployed services in the grid.</returns>
+ ICollection<IClientServiceDescriptor> ServiceDescriptors();
+
+ /// <summary>
+ /// Gets metadata about deployed services in the grid.
+ /// </summary>
+ /// <param name="serviceName">Service name</param>
+ /// <returns>Metadata about all deployed services in the grid.</returns>
+ IClientServiceDescriptor ServiceDescriptor(string serviceName);
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] ptupitsyn commented on a change in pull request #9678: IGNITE-13359 .NET: Add GetServiceDescriptor
Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on a change in pull request #9678:
URL: https://github.com/apache/ignite/pull/9678#discussion_r773305627
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Client/Services/IServicesClient.cs
##########
@@ -38,6 +40,19 @@ public interface IServicesClient
/// <returns>Proxy object that forwards all member calls to a remote Ignite service.</returns>
T GetServiceProxy<T>(string serviceName) where T : class;
+ /// <summary>
+ /// Gets metadata about all deployed services in the grid.
+ /// </summary>
+ /// <returns>Metadata about all deployed services in the grid.</returns>
+ ICollection<IClientServiceDescriptor> GetServiceDescriptors();
+
+ /// <summary>
+ /// Gets metadata about service deployed in the grid.
+ /// </summary>
+ /// <param name="serviceName">Service name</param>
Review comment:
```suggestion
/// <param name="serviceName">Service name.</param>
```
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ClientServiceDescriptor.cs
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Client.Services
+{
+ using System;
+ using Apache.Ignite.Core.Binary;
+ using Apache.Ignite.Core.Client.Services;
+
+ /// <summary>
+ /// Implementation of client service descriptor.
+ /// </summary>
+ public class ClientServiceDescriptor : IClientServiceDescriptor
+ {
+ /// <summary>
+ /// Constructor
Review comment:
```suggestion
/// Initializes a new instance of the <see cref="ClientServiceDescriptor" /> class.
```
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ClientServiceDescriptor.cs
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Client.Services
+{
+ using System;
+ using Apache.Ignite.Core.Binary;
+ using Apache.Ignite.Core.Client.Services;
+
+ /// <summary>
+ /// Implementation of client service descriptor.
+ /// </summary>
+ public class ClientServiceDescriptor : IClientServiceDescriptor
Review comment:
```suggestion
internal class ClientServiceDescriptor : IClientServiceDescriptor
```
##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Client/Services/ClientServiceDescriptor.cs
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+namespace Apache.Ignite.Core.Impl.Client.Services
+{
+ using System;
+ using Apache.Ignite.Core.Binary;
+ using Apache.Ignite.Core.Client.Services;
+
+ /// <summary>
+ /// Implementation of client service descriptor.
+ /// </summary>
+ public class ClientServiceDescriptor : IClientServiceDescriptor
+ {
+ /// <summary>
+ /// Constructor
+ /// </summary>
+ /// <param name="reader">Reader</param>
Review comment:
```suggestion
/// <param name="reader">Reader.</param>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org