You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/20 09:35:00 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #24399: Upgrade FAB to 4.1.1

uranusjr commented on code in PR #24399:
URL: https://github.com/apache/airflow/pull/24399#discussion_r901458182


##########
airflow/www/api/experimental/endpoints.py:
##########
@@ -70,7 +70,8 @@ def add_deprecation_headers(response: Response):
     return response
 
 
-api_experimental.after_request(add_deprecation_headers)
+# This is really experimental. We do not care too much about typing here
+api_experimental.after_request(add_deprecation_headers)  # type: ignore[arg-type]

Review Comment:
   Maybe we should start calling this _deprecated_ API. (It’d still show _experiemental_ in code for compatibility for now, but we can call it deprecated in docs and comments.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org