[GitHub] rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #2465: CLOUDSTACK-10232: SystemVMs and VR to run as HVM on XenServer
URL: https://github.com/apache/cloudstack/pull/2465#discussion_r185440771
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/setup/cloud-early-config
 ##########
 @@ -64,10 +71,17 @@ config_guest() {
 
 get_boot_params() {
   case $HYPERVISOR in
-     xen-domU|xen-hvm)
+     xen-pv)
           cat /proc/cmdline > $CMDLINE
           sed -i "s/%/ /g" $CMDLINE
           ;;
+     xen-hvm)
+          if [ ! -f /usr/sbin/xenstore-read ]; then
+            log_it "ERROR: xentools not installed, cannot found xenstore-read" && exit 5
+          fi
+          /usr/sbin/xenstore-read vm-data/cloudstack/init > /var/cache/cloud/cmdline
 
 Review comment:
   @khos2ow in 4.11 systemvmtemplate, the xenstore-read is at /usr/bin, can you check/comment why /usr/sbin was used? I've however, fixed this blocker in the stabilization PR: https://github.com/shapeblue/cloudstack/commit/3dbb2e6b4b98cba9d59b241bd0a8c2a051131cbc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services