You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/07 07:31:08 UTC

[GitHub] [shardingsphere] linghengqian commented on issue #17948: Add more JSR-310 classes support to IntervalShardingAlgorithm that are not yet supported

linghengqian commented on issue #17948:
URL: https://github.com/apache/shardingsphere/issues/17948#issuecomment-1148301523

   - According to java.time.temporal.TemporalQueries#chronology, we can divide the JSR310 classes that need to be supported into various types. 
   
   - The smallest java.time.temporal.ChronoUnit is NANOS, there are LocalTime, LocalDateTime, ZonedDateTime, OffsetTime, OffsetDateTime, ChronoLocalDateTime ,ChronoZonedDateTime,Instant. 
   
   - The smallest java.time.temporal.ChronoUnit is DAYS, there are LocalDate, ChronoLocalDate. 
   
   - The smallest java.time.temporal.ChronoUnit is MONTHS, there is YearMonth. 
   
   - The smallest java.time.temporal.ChronoUnit is YEARS, there is Year. 
   
   - Temporary Era, MonthDay, ZoneOffset, DayOfWeek are not considered. 
   
   - Since java.time.temporal.TemporalQueries#chronology cannot directly act on the TemporalAccessor interface, I think we should consider using TemporalAccessor#isSupported with ChronoField.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org