[GitHub] [airflow] dstandish edited a comment on pull request #21167: Add a session backend to store session data in the database

[GitBox <gi...@apache.org>]

dstandish edited a comment on pull request #21167:
URL: https://github.com/apache/airflow/pull/21167#issuecomment-1031743721


   > @jedcunningham Some of the code your wanted changes to is the vendored in code. I intentionally made as minimal modifications to that code as I needed, with the intent to possibly make a PR to upstream Flask-Session, get that merged, and migrate to using that (and removing our vendored code). The more and more in-depth modifications we make to the vendored code, the more difficult it will be to switch in the future.
   I'm happy to make the changes you noted if you'd still like me to (please let me know), I just wanted to bring that to your attention first.
   
   On this topic, thinking out loud...
   
   If we're trying to be able to easily understand what changes we've made to the vendored code, should we merge it in first with no changes?  then make PRs on top of that which modify its behavior?
   Then we'd be able to tell exactly what we did to it (instead of vendoring and changing in one commit / pr).
   And it would make the PRs easier to review too.
   
   Alternatively I don't think we do submodules 'round here but is this a valid case for it?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org