You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/01/27 17:21:16 UTC
Review Request 42857: Unit tests for Oozie are not executed (test run
is successful)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42857/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi Brodetskyi.
Bugs: AMBARI-14815
https://issues.apache.org/jira/browse/AMBARI-14815
Repository: ambari
Description
-------
Test run reports that all tests passed.
But Oozie tests are silently stopped with an exception
Traceback (most recent call last):
File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
self.run()
File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
self._target(*self._args, **self._kwargs)
File "/home/andrii/my/repos/ambari/ambari-server/src/test/python/unitTests.py", line 118, in stack_test_executor
modules]
File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName
module = __import__('.'.join(parts_copy))
File "/home/andrii/my/repos/ambari/ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py", line 94
dfs_type = '',
SyntaxError: keyword argument repeated
unitTests.py should notify about the failure (in case of syntax error), not silently reject tests.
Diffs
-----
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 5fc2cfb
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_client.py 4c1a9bc
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d167ef3
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py 4033534
ambari-server/src/test/python/unitTests.py 7bc258d
Diff: https://reviews.apache.org/r/42857/diff/
Testing
-------
unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 42857: Unit tests for Oozie are not executed (test
run is successful)
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42857/#review116589
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Січ. 27, 2016, 6:21 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42857/
> -----------------------------------------------------------
>
> (Updated Січ. 27, 2016, 6:21 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-14815
> https://issues.apache.org/jira/browse/AMBARI-14815
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Test run reports that all tests passed.
> But Oozie tests are silently stopped with an exception
>
>
> Traceback (most recent call last):
> File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
> self.run()
> File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
> self._target(*self._args, **self._kwargs)
> File "/home/andrii/my/repos/ambari/ambari-server/src/test/python/unitTests.py", line 118, in stack_test_executor
> modules]
> File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName
> module = __import__('.'.join(parts_copy))
> File "/home/andrii/my/repos/ambari/ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py", line 94
> dfs_type = '',
> SyntaxError: keyword argument repeated
>
>
> unitTests.py should notify about the failure (in case of syntax error), not silently reject tests.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 5fc2cfb
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_client.py 4c1a9bc
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py d167ef3
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_service_check.py 4033534
> ambari-server/src/test/python/unitTests.py 7bc258d
>
> Diff: https://reviews.apache.org/r/42857/diff/
>
>
> Testing
> -------
>
> unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>