[GitHub] [flink] zentol commented on a diff in pull request #19469: [FLINK-27222][coordination] Decouple last (al)location from execution history

[GitBox <gi...@apache.org>]

zentol commented on code in PR #19469:
URL: https://github.com/apache/flink/pull/19469#discussion_r850400271


##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java:
##########
@@ -313,11 +296,15 @@ private <T> Optional<T> getLatestPriorProperty(Function<ArchivedExecution, T> ex
      * @return The latest prior execution location, or null, if there is none, yet.
      */
     public Optional<TaskManagerLocation> findLatestPriorLocation() {

Review Comment:
   Had the same thoughts, but one could argue that whether it is set or find through some fancy algorithm is an implementation detail, so I reverted it.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionVertex.java:
##########
@@ -313,11 +296,15 @@ private <T> Optional<T> getLatestPriorProperty(Function<ArchivedExecution, T> ex
      * @return The latest prior execution location, or null, if there is none, yet.
      */
     public Optional<TaskManagerLocation> findLatestPriorLocation() {

Review Comment:
   Had the same thoughts, but one could argue that whether it is set or found through some fancy algorithm is an implementation detail, so I reverted it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org