[GitHub] [nifi] exceptionfactory commented on a diff in pull request #4044: NIFI-4957: Add ability to get JOLT transform from file

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory commented on code in PR #4044:
URL: https://github.com/apache/nifi/pull/4044#discussion_r1194307760


##########
nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java:
##########
@@ -141,12 +145,23 @@ public class JoltTransformRecord extends AbstractProcessor {
     static final PropertyDescriptor JOLT_SPEC = new PropertyDescriptor.Builder()
             .name("jolt-record-spec")
             .displayName("Jolt Specification")
-            .description("Jolt Specification for transform of record data. This value is ignored if the Jolt Sort Transformation is selected.")
+            .description("Jolt Specification for transform of record data. Only one of 'Jolt Specification' or 'Path To Jolt Specification' may be used. "
+                    + "This value is ignored if the Jolt Sort Transformation is selected.")
             .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
             .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
             .required(false)
             .build();
 
+    static final PropertyDescriptor JOLT_SPEC_FILE = new PropertyDescriptor.Builder()
+            .name("jolt-spec-file")
+            .displayName("Path To Jolt Specification")
+            .description("Path to location of a JOLT specification file. Only one of 'Jolt Specification' or 'Path To Jolt Specification' may be used. "
+                    + "This value is ignored if the Jolt Sort Transformation is selected.")
+            .required(false)
+            .identifiesExternalResource(ResourceCardinality.SINGLE, ResourceType.FILE)

Review Comment:
   @mattyb149 Is it possible to enhance the existing `Jolt Specification` property to support multiple resource types? That way the existing property could be either a text string as it is now, or a file reference.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org