You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2018/09/20 17:39:27 UTC
Review Request 68508: Added tracking of framework allocations in the
allocator Slave class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Bugs: MESOS-9182
https://issues.apache.org/jira/browse/MESOS-9182
Repository: mesos
Description
-------
This would simplify the tracking logic regarding
resource allocations in the allocator. See MESOS-9182.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
src/master/allocator/mesos/hierarchical.cpp 0b13d044d29b6ff650ace08f4173669279dbb6bc
Diff: https://reviews.apache.org/r/68508/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 68508: Added tracking of framework allocations in
the allocator Slave class.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/#review208808
-----------------------------------------------------------
PASS: Mesos patch 68508 was successfully built and tested.
Reviews applied: `['68507', '68508']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2365/mesos-review-68508
- Mesos Reviewbot Windows
On Sept. 20, 2018, 10:39 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68508/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2018, 10:39 a.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9182
> https://issues.apache.org/jira/browse/MESOS-9182
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would simplify the tracking logic regarding
> resource allocations in the allocator. See MESOS-9182.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
> src/master/allocator/mesos/hierarchical.cpp 0b13d044d29b6ff650ace08f4173669279dbb6bc
>
>
> Diff: https://reviews.apache.org/r/68508/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68508: Added tracking of framework allocations in
the allocator Slave class.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/#review213709
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 68508`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2958/mesos-review-68508
Relevant logs:
- [apply-review-68508.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2958/mesos-review-68508/logs/apply-review-68508.log):
```
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:109
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 25, 2018, 1:49 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68508/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2018, 1:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9182
> https://issues.apache.org/jira/browse/MESOS-9182
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would simplify the tracking logic regarding
> resource allocations in the allocator. See MESOS-9182.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
> src/master/allocator/mesos/hierarchical.cpp 906fddc48c52ec222b93d15d53edf9680d2cd861
>
>
> Diff: https://reviews.apache.org/r/68508/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68508: Added tracking of framework allocations in
the allocator Slave class.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/#review217615
-----------------------------------------------------------
Ship it!
Ship It!
- Andrei Sekretenko
On Sept. 3, 2019, 8:49 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68508/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2019, 8:49 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would simplify the tracking logic regarding
> resource allocations in the allocator. See MESOS-9182.
>
> Negligible performance impact:
>
> Master:
>
> BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Added 3000 agents in 77.999483ms
> Added 3000 frameworks in 16.736076171secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
> with drf sorter
> Made 3500 allocations in 15.342376944secs
> Made 0 allocation in 13.96720191secs
>
> Master + this patch:
>
> BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Added 3000 agents in 83.597048ms
> Added 3000 frameworks in 16.757011745secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
> with drf sorter
> Made 3500 allocations in 15.566366241secs
> Made 0 allocation in 14.022591871secs
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 48ba399e12129b3348b5c43b793f3428acf26d4e
> src/master/allocator/mesos/hierarchical.cpp 187de173ee2f563e2ff0f7e5c96695dd94a73970
>
>
> Diff: https://reviews.apache.org/r/68508/diff/3/
>
>
> Testing
> -------
>
> make check
> Benchmark result in the description
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68508: Added tracking of framework allocations in
the allocator Slave class.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/
-----------------------------------------------------------
(Updated Sept. 3, 2019, 1:49 p.m.)
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Changes
-------
Rebased and updated with benchmark result.
Repository: mesos
Description (updated)
-------
This would simplify the tracking logic regarding
resource allocations in the allocator. See MESOS-9182.
Negligible performance impact:
Master:
BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Added 3000 agents in 77.999483ms
Added 3000 frameworks in 16.736076171secs
Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
with drf sorter
Made 3500 allocations in 15.342376944secs
Made 0 allocation in 13.96720191secs
Master + this patch:
BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
Added 3000 agents in 83.597048ms
Added 3000 frameworks in 16.757011745secs
Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
with drf sorter
Made 3500 allocations in 15.566366241secs
Made 0 allocation in 14.022591871secs
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 48ba399e12129b3348b5c43b793f3428acf26d4e
src/master/allocator/mesos/hierarchical.cpp 187de173ee2f563e2ff0f7e5c96695dd94a73970
Diff: https://reviews.apache.org/r/68508/diff/3/
Changes: https://reviews.apache.org/r/68508/diff/2-3/
Testing (updated)
-------
make check
Benchmark result in the description
Thanks,
Meng Zhu
Re: Review Request 68508: Added tracking of framework allocations in
the allocator Slave class.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/#review209197
-----------------------------------------------------------
Ship it!
Can you do a quick benchmark comparison to see if this has a significant impact?
src/master/allocator/mesos/hierarchical.hpp
Lines 157 (patched)
<https://reviews.apache.org/r/68508/#comment293524>
If you CHECK this, should you also do a containment check before the subtraction below?
- Benjamin Mahler
On Sept. 25, 2018, 8:49 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68508/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2018, 8:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9182
> https://issues.apache.org/jira/browse/MESOS-9182
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would simplify the tracking logic regarding
> resource allocations in the allocator. See MESOS-9182.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
> src/master/allocator/mesos/hierarchical.cpp 906fddc48c52ec222b93d15d53edf9680d2cd861
>
>
> Diff: https://reviews.apache.org/r/68508/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68508: Added tracking of framework allocations in
the allocator Slave class.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/#review209008
-----------------------------------------------------------
PASS: Mesos patch 68508 was successfully built and tested.
Reviews applied: `['68507', '68508']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2397/mesos-review-68508
- Mesos Reviewbot Windows
On Sept. 25, 2018, 8:49 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68508/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2018, 8:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9182
> https://issues.apache.org/jira/browse/MESOS-9182
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would simplify the tracking logic regarding
> resource allocations in the allocator. See MESOS-9182.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
> src/master/allocator/mesos/hierarchical.cpp 906fddc48c52ec222b93d15d53edf9680d2cd861
>
>
> Diff: https://reviews.apache.org/r/68508/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68508: Added tracking of framework allocations in
the allocator Slave class.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/#review213040
-----------------------------------------------------------
Bad review!
Reviews applied: [68508, 68507]
Error:
2019-02-21 19:09:18 URL:https://reviews.apache.org/r/68508/diff/raw/ [6220/6220] -> "68508.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:109
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
- Mesos Reviewbot
On Sept. 25, 2018, 8:49 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68508/
> -----------------------------------------------------------
>
> (Updated Sept. 25, 2018, 8:49 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
>
>
> Bugs: MESOS-9182
> https://issues.apache.org/jira/browse/MESOS-9182
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would simplify the tracking logic regarding
> resource allocations in the allocator. See MESOS-9182.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
> src/master/allocator/mesos/hierarchical.cpp 906fddc48c52ec222b93d15d53edf9680d2cd861
>
>
> Diff: https://reviews.apache.org/r/68508/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 68508: Added tracking of framework allocations in
the allocator Slave class.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68508/
-----------------------------------------------------------
(Updated Sept. 25, 2018, 1:49 p.m.)
Review request for mesos, Benjamin Mahler and Gastón Kleiman.
Changes
-------
Added a getter. Also rebased.
Bugs: MESOS-9182
https://issues.apache.org/jira/browse/MESOS-9182
Repository: mesos
Description
-------
This would simplify the tracking logic regarding
resource allocations in the allocator. See MESOS-9182.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp e09a615979014909e7b88d44e6617fd1476415c5
src/master/allocator/mesos/hierarchical.cpp 906fddc48c52ec222b93d15d53edf9680d2cd861
Diff: https://reviews.apache.org/r/68508/diff/2/
Changes: https://reviews.apache.org/r/68508/diff/1-2/
Testing
-------
make check
Thanks,
Meng Zhu