You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/14 03:45:21 UTC

[GitHub] [incubator-doris] WingsGo opened a new pull request #4350: [Bug]Fix bug that BE crash when load ORC file

WingsGo opened a new pull request #4350:
URL: https://github.com/apache/incubator-doris/pull/4350


   Fix #4349 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on pull request #4350: [Bug]Fix bug that BE crash when load ORC file

Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4350:
URL: https://github.com/apache/incubator-doris/pull/4350#issuecomment-674342841


   Maybe you need to rebase to upstream master to make UT happy


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] WingsGo commented on pull request #4350: [Bug]Fix bug that BE crash when load ORC file

Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #4350:
URL: https://github.com/apache/incubator-doris/pull/4350#issuecomment-674346299


   > Maybe you need to rebase to upstream master to make UT happy
   
   @morningman OK, done~~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] WingsGo commented on pull request #4350: [Bug]Fix bug that BE crash when load ORC file

Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #4350:
URL: https://github.com/apache/incubator-doris/pull/4350#issuecomment-673929122


   For reviewers, I found that ORC include file didn't expose orc::TimezoneError, which is writer in Timezone.hh, I don't know why, so I have to catch `std::runtime_error` instead. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] WingsGo edited a comment on pull request #4350: [Bug]Fix bug that BE crash when load ORC file

Posted by GitBox <gi...@apache.org>.
WingsGo edited a comment on pull request #4350:
URL: https://github.com/apache/incubator-doris/pull/4350#issuecomment-673929122


   For reviewers, I found that ORC include file didn't expose orc::TimezoneError, which is writer in Timezone.hh, I don't know why, maybe it is a wrong design, I will submit a issue to ORC project, currently solution is declare `orc::TimezoneError` by handle or just catch `std::runtime_error` exception, I choosen the first solution because I think it is less error-prone and more reasonable. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman merged pull request #4350: [Bug]Fix bug that BE crash when load ORC file

Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4350:
URL: https://github.com/apache/incubator-doris/pull/4350


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] WingsGo edited a comment on pull request #4350: [Bug]Fix bug that BE crash when load ORC file

Posted by GitBox <gi...@apache.org>.
WingsGo edited a comment on pull request #4350:
URL: https://github.com/apache/incubator-doris/pull/4350#issuecomment-673929122


   For reviewers, I found that ORC include file didn't expose `orc::TimezoneError`, which is writer in Timezone.hh, I don't know why, maybe it is a wrong design, I will submit a issue to ORC project, currently solution is declare `orc::TimezoneError` by handle or just catch `std::runtime_error` exception, I choosen the first solution because I think it is less error-prone and more reasonable. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org