[jira] [Commented] (TINKERPOP-1062) Make LifeCycle beforeEval execute in same thread as eval operation

["stephen mallette (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068326#comment-15068326 ] 

stephen mallette commented on TINKERPOP-1062:
---------------------------------------------

Implemented this change here:

https://github.com/apache/incubator-tinkerpop/commit/d85a35d8741a5e534c0c45b194a716de10803198

Still reviewing to be sure it's that straightforward.

> Make LifeCycle beforeEval execute in same thread as eval operation
> ------------------------------------------------------------------
>
>                 Key: TINKERPOP-1062
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1062
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: groovy
>    Affects Versions: 3.1.0-incubating
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>            Priority: Minor
>             Fix For: 3.1.1-incubating
>
>
> {{GremlinExecutor}} currently performs its {{beforeEval}} event outside of the thread that does the {{eval()}} itself.  This can be problematic, if a user wants to make configurations specific to that {{eval()}} thread of execution or alter bindings via {{ThreadLocal}}. 
> It's worth noting that this isn't a major change (basically moving a line of code) and should not break any existing use cases.  Pretty simple.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)