You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "binitshrest (via GitHub)" <gi...@apache.org> on 2024/09/05 13:05:16 UTC
[PR] [Improvement-16507][alert] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
binitshrest opened a new pull request, #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
<!-- I changed and removed the some extra dependencies that should be removed after removing spring-boot-starter-cache from pom.xml and application.properties file. That has caused the issues. After removing extra dependencies and the server runs smoothly with out any bugs -->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2426086091
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2408972403
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1798303011
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-oss/pom.xml:
##########
@@ -43,6 +43,16 @@
<artifactId>dolphinscheduler-common</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is provided.
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-jdbc/pom.xml:
##########
@@ -97,6 +97,16 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is test.
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-s3/pom.xml:
##########
@@ -50,6 +50,16 @@
<artifactId>dolphinscheduler-common</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is provided.
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-abs/pom.xml:
##########
@@ -43,6 +43,12 @@
<artifactId>dolphinscheduler-common</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is provided.
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-cos/pom.xml:
##########
@@ -36,6 +36,12 @@
<artifactId>dolphinscheduler-common</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is provided.
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-obs/pom.xml:
##########
@@ -43,6 +43,16 @@
<artifactId>dolphinscheduler-common</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is provided.
##########
dolphinscheduler-extract/dolphinscheduler-extract-worker/pom.xml:
##########
@@ -34,10 +34,30 @@
<groupId>org.apache.dolphinscheduler</groupId>
<artifactId>dolphinscheduler-extract-common</artifactId>
<version>${project.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
<dependency>
<groupId>org.apache.dolphinscheduler</groupId>
<artifactId>dolphinscheduler-extract-base</artifactId>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since these has been managed by dependencyManagement under root pom.xml.
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-it/pom.xml:
##########
@@ -35,6 +35,16 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is test.
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-hdfs/pom.xml:
##########
@@ -50,6 +50,16 @@
<artifactId>dolphinscheduler-common</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is provided.
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-zookeeper/pom.xml:
##########
@@ -96,6 +96,16 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is test.
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-gcs/pom.xml:
##########
@@ -43,6 +43,16 @@
<artifactId>dolphinscheduler-common</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is provided.
##########
dolphinscheduler-master/pom.xml:
##########
@@ -283,6 +268,12 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is test.
##########
dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-etcd/pom.xml:
##########
@@ -74,6 +74,16 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.logging.log4j</groupId>
+ <artifactId>log4j-to-slf4j</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
Do we need to add exclusions here? since this scope is test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2410999176
> > Please retry analysis of this Pull-Request directly on SonarCloud
>
> Do i have to worry about this sir? @ruanwenjun
No, this is not related to your change, and will not block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2410996524
> Please retry analysis of this Pull-Request directly on SonarCloud
Do i have to worry about this sir? @ruanwenjun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2333188666
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate failed**
Failed conditions
 [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2407674457
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2407677029
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2408291557
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2409806053
> @ruanwenjun sir. Did i solve this issue? Please let me know. I am encouraged that all the checks are passed.
Yes, the dependency has passed. But there are some extra things need to do.
1. Please remove two license files
```
`dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-api-2.11.2.txt`
`dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-core-2.11.2.txt`
```
Since you have removed these from LICENSE, and we really don't rely on these, good job, you have solved a new problem.
2. I am not sure if we need to add exclusion in all place, I add comment. Since once we add these, it will be hard to remove in the future, my experience is we only need to exclude these in dependencymanagement. It's need to have a try.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1797091565
##########
.gitignore:
##########
@@ -55,3 +55,6 @@ dolphinscheduler-master/logs
dolphinscheduler-api/logs
__pycache__
ds_schema_check_test
+.env.txt
+venv
+myenv
Review Comment:
We need to find out where these two dependencies are imported, and exclude these, otherwise the ci will failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2408972881
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest closed pull request #16593: [Improvement-16507] Remove spring-boot-starter-cache
URL: https://github.com/apache/dolphinscheduler/pull/16593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][alert] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2331632357
Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1792890332
##########
dolphinscheduler-ui/pnpm-lock.yaml:
##########
@@ -73,7 +57,7 @@ dependencies:
echarts: 5.4.2
js-cookie: 3.0.5
lodash: 4.17.21
- monaco-editor: 0.34.1
+ monaco-editor: 0.50.0
Review Comment:
Please revert this file, this change is not related with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1793010307
##########
dolphinscheduler-ui/pnpm-lock.yaml:
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-lockfileVersion: 5.4
+lockfileVersion: 5.3
Review Comment:
Please do not change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2408291087
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2425723184
This issue was closed accidentally. I am reopening this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2333783978
@caishunfeng Can you please guide me to fix 5 failing issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2333606058
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate failed**
Failed conditions
 [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1796319715
##########
.gitignore:
##########
@@ -55,3 +55,6 @@ dolphinscheduler-master/logs
dolphinscheduler-api/logs
__pycache__
ds_schema_check_test
+.env.txt
+venv
+myenv
Review Comment:
Please remove this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2408974237
@ruanwenjun sir. Did i solve this issue? Please let me know. I am encouraged that all the checks are passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2336950117
You should check these two dependency. @binitshrest
```
log4j-api-2.17.2.jar
log4j-to-slf4j-2.17.2.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2351012526
Hi @ruanwenjun,
Sure. I will revert this change asap and will work on this bug. I will appreciate a help from you? My project is failing to build with docker setup and other env setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2351658494
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate failed**
Failed conditions
 [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2351659230
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate failed**
Failed conditions
 [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1793030984
##########
dolphinscheduler-ui/pnpm-lock.yaml:
##########
@@ -14,7 +14,7 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-lockfileVersion: 5.4
+lockfileVersion: 5.3
Review Comment:
Sure. On it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2333190062
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate failed**
Failed conditions
 [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2333262312
> We should remove the code and dependency of spring-boot-starter-cache.
Hi ruanwenjun,
After carefully observing and understanding the codebase. I have removed the extra dependency of the spring-boot-starter-cache which includes the related annotations like cacheable and cacheconfig. I removed it and the codebase runs without any issues. I am open for some more suggestions from your side. As spring-boot-starter-cache dependency has been removed from POM.xml and application.properties files. I went some more depth and removed some related annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2333673122
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate failed**
Failed conditions
 [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2425872575
> This issue was closed accidentally. I am reopening this issue.
Reopening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2406376028
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1796355362
##########
.gitignore:
##########
@@ -55,3 +55,6 @@ dolphinscheduler-master/logs
dolphinscheduler-api/logs
__pycache__
ds_schema_check_test
+.env.txt
+venv
+myenv
Review Comment:
Sure. Sir. Thank you. I will also try to find a way to exclude these log4j-api and log4j-to-slf4j. I was looking on the same too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2371830216
@SbloodyS Because of so many vulnerabilities found in this project i.e due to old dependencies of mavens. The codebase is failing to build. please allow me to change all the dependencies or any suggestion will appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2413162401
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2426081954
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2426084243
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2331791694
> Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
Hi, Can you please review if i updated based on the given documentations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2337236741
> > You should check these two dependency. @binitshrest
> > ```
> > log4j-api-2.17.2.jar
> > log4j-to-slf4j-2.17.2.jar
> > ```
>
> > log4j-to-slf4j-2.17.2.jar
>
> Thank you @SbloodyS. I found them. There are so many of these dependencies. Should i remove them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1797148168
##########
.gitignore:
##########
@@ -55,3 +55,6 @@ dolphinscheduler-master/logs
dolphinscheduler-api/logs
__pycache__
ds_schema_check_test
+.env.txt
+venv
+myenv
Review Comment:
Sure. Sir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2409818560
> > @ruanwenjun sir. Did i solve this issue? Please let me know. I am encouraged that all the checks are passed.
>
> @binitshrest Yes, the ci has passed. But there are some extra things need to do.
>
> 1. Please remove two license files
>
> ```
> `dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-api-2.11.2.txt`
> `dolphinscheduler-dist/release-docs/licenses/LICENSE-log4j-core-2.11.2.txt`
> ```
>
> Since you have removed these from LICENSE, and we really don't rely on these, good job, you have solved a new problem. 2. I am not sure if we need to add exclusion in all place, I add comment. Since once we add these, it will be hard to remove in the future, my experience is we only need to exclude these in dependencymanagement. It's need to have a try.
Yes, Sir. We don't need to add that exclusion code in all place. I saw in this morning. Once i put that exclusion in root dependency. It will remove from all. I am not sure if i should remove from test scope . I will make also some changes what you have said earlier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2410559779
Please retry analysis of this Pull-Request directly on SonarCloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1807609568
##########
.gitignore:
##########
@@ -54,4 +54,4 @@ dolphinscheduler-worker/logs
dolphinscheduler-master/logs
dolphinscheduler-api/logs
__pycache__
-ds_schema_check_test
+ds_schema_check_test
Review Comment:
This is still unaddressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1746719910
##########
dolphinscheduler-standalone-server/src/main/resources/application.yaml:
##########
@@ -1,4 +1,4 @@
-#
+ #
Review Comment:
This change is not changed.
##########
dolphinscheduler-bom/pom.xml:
##########
@@ -927,10 +927,6 @@
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-core</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-api</artifactId>
- </exclusion>
Review Comment:
Why remove this?
##########
dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/BaseDataSourceParamDTO.java:
##########
@@ -117,7 +117,7 @@ public void setHostAndPortByAddress(String address) {
}
this.host = String.join(Constants.COMMA, hosts);
- this.port = Integer.parseInt(portString);
+ this.port = (Integer) Integer.parseInt(portString);
Review Comment:
This change is not needed
##########
dolphinscheduler-api/pom.xml:
##########
@@ -121,10 +121,6 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-tomcat</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.apache.logging.log4j</groupId>
- <artifactId>log4j-to-slf4j</artifactId>
- </exclusion>
Review Comment:
Why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2351645938
Hi @ruanwenjun , the build is succesfully complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2333605952
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate failed**
Failed conditions
 [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2337236110
> You should check these two dependency. @binitshrest
>
> ```
> log4j-api-2.17.2.jar
> log4j-to-slf4j-2.17.2.jar
> ```
> log4j-to-slf4j-2.17.2.jar
Thank you SbloodyS. I found them. There are so many of these dependencies. Should i remove them too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2333674300
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate failed**
Failed conditions
 [C Maintainability Rating on New Code](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) (required ≥ A)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "binitshrest (via GitHub)" <gi...@apache.org>.
binitshrest commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1792899356
##########
dolphinscheduler-ui/pnpm-lock.yaml:
##########
@@ -73,7 +57,7 @@ dependencies:
echarts: 5.4.2
js-cookie: 3.0.5
lodash: 4.17.21
- monaco-editor: 0.34.1
+ monaco-editor: 0.50.0
Review Comment:
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2401691290
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507][Remove spring-boot-starter-cache dependency] Improve the performance of spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2401690436
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2410558892
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [2 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#discussion_r1800594205
##########
.gitignore:
##########
@@ -54,4 +54,4 @@ dolphinscheduler-worker/logs
dolphinscheduler-master/logs
dolphinscheduler-api/logs
__pycache__
-ds_schema_check_test
+ds_schema_check_test
Review Comment:
Please avoid unnessnary chanage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593#issuecomment-2413160383
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16593&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16593&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16593)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-16507] Remove spring-boot-starter-cache [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #16593:
URL: https://github.com/apache/dolphinscheduler/pull/16593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org