[GitHub] [couchdb] davisp commented on a change in pull request #2343: Allow all params to be passed via body for POST _all_docs

[GitBox <gi...@apache.org>]

davisp commented on a change in pull request #2343: Allow all params to be passed via body for POST _all_docs
URL: https://github.com/apache/couchdb/pull/2343#discussion_r355022082
 
 

 ##########
 File path: src/chttpd/src/chttpd_show.erl
 ##########
 @@ -204,7 +204,7 @@ handle_view_list(Req, Db, DDoc, LName, {ViewDesignName, ViewName}, Keys) ->
     DbName = couch_db:name(Db),
     {ok, VDoc} = ddoc_cache:open(DbName, <<"_design/", ViewDesignName/binary>>),
     CB = fun list_cb/2,
-    QueryArgs = couch_mrview_http:parse_params(Req, Keys),
+    Args = couch_mrview_http:parse_body_and_query(Req, Keys),
 
 Review comment:
   I'd not change the variable name here which will shorten the diff. I assume that was done because its now more than the query string. Though we refer to view reads as queries in multiple places so there's no harm leaving it as QueryArgs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services