[jira] [Closed] (BVAL-82) Validation of inherited methods causes ValidationException

["Matt Benson (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BVAL-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Benson closed BVAL-82.
---------------------------
    Resolution: Won't Fix

method validation is standardized in bean validation 1.1; closing all related issues from before BVal 1.1.0.

> Validation of inherited methods causes ValidationException
> ----------------------------------------------------------
>
>                 Key: BVAL-82
>                 URL: https://issues.apache.org/jira/browse/BVAL-82
>             Project: BVal
>          Issue Type: Bug
>          Components: method validation
>    Affects Versions: 0.1-incubating, 0.2-incubating, 0.3-incubating, 0.4, 0.5
>            Reporter: Daniel Drachau
>            Assignee: Mohammad Nour
>             Fix For: 1.0
>
>
> MethodValidationImpl throws an exception if it tries to verify an inherited method (definition in the abstract superclass).
> {code}
>   public <T> Set<ConstraintViolation<T>> validateParameter(Class<T> clazz, Method method,
>                                                            Object parameter,
>                                                            int parameterIndex,
>                                                            Class<?>... groupArray) {
>     MethodBeanDescriptorImpl beanDesc =
>         (MethodBeanDescriptorImpl) getConstraintsForClass(clazz);
>     MethodDescriptorImpl methodDescriptor =
>         (MethodDescriptorImpl) beanDesc.getConstraintsForMethod(method);
>     if ( methodDescriptor == null ) {
> -->        throw new ValidationException("Method " + method + " doesn't belong to class " + clazz);
>     }
> {code}
> a possible fix might be to collect the method declarations of the parent classes as well (in the MethodValidatorMetaBeanFactory). I cannot decide if this really fix the problem or just one symptom.
> {code}
>   private void buildMethodConstraints(MethodBeanDescriptorImpl beanDesc)
>       throws InvocationTargetException, IllegalAccessException {
>     beanDesc.setMethodConstraints(new HashMap<Method, MethodDescriptor>());
> ### new ###
>     ArrayList<Method> methods = new ArrayList<Method>();
>     for (Method m : beanDesc.getMetaBean().getBeanClass().getDeclaredMethods()) {
>       methods.add(m);
>     }
>     Class clazz = beanDesc.getMetaBean().getBeanClass();
>     while (clazz.getSuperclass() != null) {
>       clazz = clazz.getSuperclass();
>       for (Method m : clazz.getDeclaredMethods()) {
>         methods.add(m);
>       }
>     }
>     for (Method method : methods) {
> ### end new ###
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)