[GitHub] [solr] HoustonPutman commented on a diff in pull request #1552: SOLR-16714: addDepsToChanges.py handle empty gitlog

["HoustonPutman (via GitHub)" <gi...@apache.org>]

HoustonPutman commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161733279


##########
dev-tools/scripts/addDepsToChanges.py:
##########
@@ -102,6 +104,11 @@ def update_changes(filename, version, changes_lines):
                         buffer.append(change_line)
                         buffer.append("\n")
                     continue
+            else:

Review Comment:
   Don't think you need an `else` here, but it doesn't really matter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org