[GitHub] ningyougang edited a comment on issue #4058: Add protect feature to avoid delete actions by mistake

[GitBox <gi...@apache.org>]

ningyougang edited a comment on issue #4058: Add protect feature to avoid delete actions by mistake
URL: https://github.com/apache/incubator-openwhisk/pull/4058#issuecomment-428034588
 
 
   @cbickel @rabbah ,thanks for your quick reply.
   
   Actually, i opened a pr first here: https://github.com/apache/incubator-openwhisk-cli/pull/372
   Solve the update/delete mistake on CLI side, after think deeply, i found, it is better to solve it in backend layer.(So don't merge that pull/372 temporarily)
   
   As you give two suggestions
   * You are adding the protection-parameter as URL parameter
   Actually, i passed the `protection` as URL parameter` the same as `overwrite`,
   If don't pass as URL parameter, has any other good method, how about pass as a Http Header, for example：-H "OW_PROTECTION: true" 
   
   * Or would it make sense to protect it against updates as well?
   I agree, i think this also, yestoday, i push it to here, just check whether upstream guys agree this ` protect delete/update mistake feature`
   
   And regarding `The trick here would be to allow the update to unlock the action again`
   How about pass a special flag(e.g pass a  URL parameter: unlock=true).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services