[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #6172: Add parquet filter and sort to bench.sh

["comphead (via GitHub)" <gi...@apache.org>]

comphead commented on code in PR #6172:
URL: https://github.com/apache/arrow-datafusion/pull/6172#discussion_r1182704695


##########
benchmarks/bench.sh:
##########
@@ -247,6 +257,22 @@ run_tpch_mem() {
     $CARGO_COMMAND --bin tpch -- benchmark datafusion --iterations 5 --path "${DATA_DIR}" -m --format parquet -o ${RESULTS_FILE}
 }
 
+# Runs the parquet filter benchmark
+run_parquet() {
+    RESULTS_FILE="${RESULTS_DIR}/parquet.json"
+    echo "RESULTS_FILE: ${RESULTS_FILE}"
+    echo "Running parquet filter benchmark..."
+    $CARGO_COMMAND --bin parquet -- filter --path "${DATA_DIR}" --scale-factor 1.0 --iterations 5 -o ${RESULTS_FILE}

Review Comment:
   why we dont apply scale-factor for tpch? is it 1 by default?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org