You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2008/05/03 07:00:56 UTC
[jira] Commented: (HADOOP-3338) trunk doesn't compile after
HADOOP-544 was committed
[ https://issues.apache.org/jira/browse/HADOOP-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593972#action_12593972 ]
Hadoop QA commented on HADOOP-3338:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12381319/3338-20080502a.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2368/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2368/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2368/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2368/console
This message is automatically generated.
> trunk doesn't compile after HADOOP-544 was committed
> ----------------------------------------------------
>
> Key: HADOOP-3338
> URL: https://issues.apache.org/jira/browse/HADOOP-3338
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.18.0
> Reporter: Nigel Daley
> Assignee: Christophe Taton
> Priority: Blocker
> Fix For: 0.18.0
>
> Attachments: 3338-20080502a.patch
>
>
> For all the discussion about deprectatoin, etc, the patch for HADOOP-544 has broken trunk! It no longer compiles on Hudson. The contrib eclipse plugin relied on an API that you considered non-Public (JobStatus and perhaps others). Given we have no well defined public API yet, I don't think you can assume that classes declared "public" aren't actually public. At a minimum, the release notes should indicated that methods were removed and not deprecated.
> Build failure:
> http://hudson.zones.apache.org/hudson/view/Hadoop/job/Hadoop-trunk/476/console
> {quote}
> compile:
> [echo] contrib: eclipse-plugin
> [javac] Compiling 45 source files to /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-trunk/workspace/trunk/build/contrib/eclipse-plugin/classes
> [javac] /zonestorage/hudson/home/hudson/hudson/jobs/Hadoop-trunk/workspace/trunk/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java:119: cannot find symbol
> [javac] symbol : method getJobId()
> [javac] location: class org.apache.hadoop.mapred.JobStatus
> [javac] String jobId = status.getJobId();
> [javac] ^
> [javac] Note: Some input files use or override a deprecated API.
> [javac] Note: Recompile with -Xlint:deprecation for details.
> [javac] Note: Some input files use unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 1 error
> {quote}
> Can we get this fixed today?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.