You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 15:46:05 UTC
[PR] test: cover null guards and blank-instance normalization in ConsumerDiagnosticsService [rocketmq-dashboard]
yyqdbngt opened a new pull request, #3433:
URL: https://github.com/apache/rocketmq-dashboard/pull/3433
### Summary
`ConsumerDiagnosticsService` requires a group and client id but treats the instance id as optional before delegating to the provider. The suite covered blank group/client rejection but not the `null` forms or instance normalization.
### Changes
- `null` group names and client ids are rejected with the same required-field messages
- A blank instance id is normalized to `null` before the provider call
### Testing
`mvn test -Dtest=ConsumerDiagnosticsServiceTest` passes: 6 tests, 0 failures (up from 4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover null guards and blank-instance normalization in ConsumerDiagnosticsService [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3433: test: cover null guards and blank-instance normalization in ConsumerDiagnosticsService
URL: https://github.com/apache/rocketmq-dashboard/pull/3433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org