[GitHub] rob05c commented on issue #2732: Unable to Edit or Delete a Tenant where Active is false

[GitBox <gi...@apache.org>]

rob05c commented on issue #2732: Unable to Edit or Delete a Tenant where Active is false
URL: https://github.com/apache/trafficcontrol/issues/2732#issuecomment-448679801
 
 
   I'm hitting this issue, trying to fix the TO API Tests for tenancy.
   
   >I've dug a bit into this issue, and I believe the issue is in IsResourceAuthorizedToUserTx, >specifically line 197 in tenancy.go. The expected behavior is that an active tenant that is the parent >of any inactive tenant should still be able to modify that tenant.
   >I'd suggest that the active in this case refer to the activity of the requesting user's tenant, not the >activity of the tenant being modified.
   
   I think I agree. I think the solution is to fix the query in `IsResourceAuthorizedToUserTx` to return true if the user's tenant is active, and is a parent of the resource's tenant, irrespective whether the resource's direct tenant is active.
   
   I also agree with the discussion on the mailing list, that there are bigger issues with how tenancy and activity is treated. But I think it's worth fixing the immediate bug, if it isn't too difficult, even before we figure out the larger solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services