You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@archiva.apache.org by Brett Porter <br...@apache.org> on 2007/08/14 14:12:00 UTC
Re: svn commit: r565709 - /maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
well spotted!
just wondering, should this be in a finally block? (I'm not sure
where the IOException actually comes from, and whether it occurs
after the searcher is opened or not).
- Brett
On 14/08/2007, at 9:34 PM, oching@apache.org wrote:
> Author: oching
> Date: Tue Aug 14 04:34:04 2007
> New Revision: 565709
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=565709
> Log:
> - MultiSearcher for index is not being closed causing too many
> files open error, added line for close searcher
>
>
> Modified:
> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/
> org/apache/maven/archiva/indexer/search/
> DefaultCrossRepositorySearch.java
>
> Modified: maven/archiva/trunk/archiva-base/archiva-indexer/src/main/
> java/org/apache/maven/archiva/indexer/search/
> DefaultCrossRepositorySearch.java
> URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/
> archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/
> search/DefaultCrossRepositorySearch.java?
> view=diff&rev=565709&r1=565708&r2=565709
> ======================================================================
> ========
> --- maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/
> org/apache/maven/archiva/indexer/search/
> DefaultCrossRepositorySearch.java (original)
> +++ maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/
> org/apache/maven/archiva/indexer/search/
> DefaultCrossRepositorySearch.java Tue Aug 14 04:34:04 2007
> @@ -237,6 +237,8 @@
> }
> }
> }
> +
> + searcher.close();
> }
> catch ( IOException e )
> {
>
Re: svn commit: r565709 - /maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
Posted by Maria Odea Ching <oc...@devzuz.com>.
yeah, i think this should be in the finally block.
i'll fix this up :)
Thanks,
Deng
Brett Porter wrote:
> well spotted!
>
> just wondering, should this be in a finally block? (I'm not sure where
> the IOException actually comes from, and whether it occurs after the
> searcher is opened or not).
>
> - Brett
>
> On 14/08/2007, at 9:34 PM, oching@apache.org wrote:
>
>> Author: oching
>> Date: Tue Aug 14 04:34:04 2007
>> New Revision: 565709
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=565709
>> Log:
>> - MultiSearcher for index is not being closed causing too many files
>> open error, added line for close searcher
>>
>>
>> Modified:
>> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
>>
>>
>> Modified:
>> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java?view=diff&rev=565709&r1=565708&r2=565709
>>
>> ==============================================================================
>>
>> ---
>> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
>> (original)
>> +++
>> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
>> Tue Aug 14 04:34:04 2007
>> @@ -237,6 +237,8 @@
>> }
>> }
>> }
>> +
>> + searcher.close();
>> }
>> catch ( IOException e )
>> {
>>
>
Re: svn commit: r565709 - /maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
Posted by Maria Odea Ching <oc...@devzuz.com>.
yeah, i think this should be in the finally block.
i'll fix this up :)
Thanks,
Deng
Brett Porter wrote:
> well spotted!
>
> just wondering, should this be in a finally block? (I'm not sure where
> the IOException actually comes from, and whether it occurs after the
> searcher is opened or not).
>
> - Brett
>
> On 14/08/2007, at 9:34 PM, oching@apache.org wrote:
>
>> Author: oching
>> Date: Tue Aug 14 04:34:04 2007
>> New Revision: 565709
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=565709
>> Log:
>> - MultiSearcher for index is not being closed causing too many files
>> open error, added line for close searcher
>>
>>
>> Modified:
>> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
>>
>>
>> Modified:
>> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
>>
>> URL:
>> http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java?view=diff&rev=565709&r1=565708&r2=565709
>>
>> ==============================================================================
>>
>> ---
>> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
>> (original)
>> +++
>> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
>> Tue Aug 14 04:34:04 2007
>> @@ -237,6 +237,8 @@
>> }
>> }
>> }
>> +
>> + searcher.close();
>> }
>> catch ( IOException e )
>> {
>>
>