You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@deltaspike.apache.org by st...@apache.org on 2021/03/03 17:41:37 UTC
[deltaspike] branch master updated: DELTASPIKE-1423 exlude tests
which are broken w JSF-2.3
This is an automated email from the ASF dual-hosted git repository.
struberg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/deltaspike.git
The following commit(s) were added to refs/heads/master by this push:
new 181490a DELTASPIKE-1423 exlude tests which are broken w JSF-2.3
181490a is described below
commit 181490a80e0159606199eb8509448bf468700178
Author: Mark Struberg <st...@apache.org>
AuthorDate: Wed Mar 3 18:40:23 2021 +0100
DELTASPIKE-1423 exlude tests which are broken w JSF-2.3
JSF-2.3 introduced some nasty backward incompatibilities.
Discussed with Gerhard - we rather should exclude them for now
if running on a container supporting JSF-2.3.
---
deltaspike/modules/data/impl/pom.xml | 13 +++++++++++++
deltaspike/modules/jsf/impl/pom.xml | 26 ++++++++++++++++++++++++++
2 files changed, 39 insertions(+)
diff --git a/deltaspike/modules/data/impl/pom.xml b/deltaspike/modules/data/impl/pom.xml
index 1001b9c..8a8dbc3 100755
--- a/deltaspike/modules/data/impl/pom.xml
+++ b/deltaspike/modules/data/impl/pom.xml
@@ -309,6 +309,19 @@
</build>
</profile>
<profile>
+ <id>tomee8-build-managed</id>
+ <build>
+ <testResources>
+ <testResource>
+ <directory>src/test/resources</directory>
+ </testResource>
+ <testResource>
+ <directory>src/test/resources-openejb</directory>
+ </testResource>
+ </testResources>
+ </build>
+ </profile>
+ <profile>
<id>wls-remote-12c</id>
<build>
<testResources>
diff --git a/deltaspike/modules/jsf/impl/pom.xml b/deltaspike/modules/jsf/impl/pom.xml
index 2e4ea7a..14d9e40 100644
--- a/deltaspike/modules/jsf/impl/pom.xml
+++ b/deltaspike/modules/jsf/impl/pom.xml
@@ -169,5 +169,31 @@
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>tomee8-build-managed</id>
+ <build>
+ <plugins>
+ <!--
+ * JSF-2.3 broke backward compatibility by trying to handle CDI beans themselves.
+ * Some JSF annotations now have a 'managed' attribute, which must be set to true
+ * to properly serve CDI Injection.
+ * This cannot be done easily in unit tests which are backward compatible by design.
+ -->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>${maven.surefire.plugin.version}</version>
+ <configuration>
+ <excludes>
+ <exclude>org/apache/deltaspike/test/jsf/impl/injection/**/*</exclude>
+ </excludes>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+ </profile>
+ </profiles>
</project>