You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/05/03 01:23:17 UTC
Review Request: SQOOP-1027 Incremental import is not properly escaping table
name when loading maximal value
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10909/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've added proper escape call to the query creation code.
This addresses bug SQOOP-1027.
https://issues.apache.org/jira/browse/SQOOP-1027
Diffs
-----
src/java/org/apache/sqoop/tool/ImportTool.java 10f0cb9
Diff: https://reviews.apache.org/r/10909/diff/
Testing
-------
Unit tests seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-1027 Incremental import is not properly escaping
table name when loading maximal value
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10909/#review20172
-----------------------------------------------------------
Ship it!
Ship It!
- Kathleen Ting
On May 2, 2013, 11:23 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10909/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 11:23 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've added proper escape call to the query creation code.
>
>
> This addresses bug SQOOP-1027.
> https://issues.apache.org/jira/browse/SQOOP-1027
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/tool/ImportTool.java 10f0cb9
>
> Diff: https://reviews.apache.org/r/10909/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>