You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/26 10:56:29 UTC
[GitHub] [incubator-shardingsphere] minghu-zhang opened a new pull request
#3811: Solve the problem when project's default charset is not utf-8
minghu-zhang opened a new pull request #3811: Solve the problem when project's default charset is not utf-8
URL: https://github.com/apache/incubator-shardingsphere/pull/3811
Fixes #3810.
Changes proposed in this pull request:
- modified：AESShardingEncryptor.java
-
-
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] minghu-zhang commented on issue #3811:
Solve the problem when project's default charset is not utf-8
Posted by GitBox <gi...@apache.org>.
minghu-zhang commented on issue #3811: Solve the problem when project's default charset is not utf-8
URL: https://github.com/apache/incubator-shardingsphere/pull/3811#issuecomment-569161088
> How about if the original string is not UTF8?
It will cause the result of decryption to be disorderly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3811:
Solve the problem when project's default charset is not utf-8
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #3811: Solve the problem when project's default charset is not utf-8
URL: https://github.com/apache/incubator-shardingsphere/pull/3811#issuecomment-569075229
How about if the original string is not UTF8?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on issue #3811:
Solve the problem when project's default charset is not utf-8
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #3811: Solve the problem when project's default charset is not utf-8
URL: https://github.com/apache/incubator-shardingsphere/pull/3811#issuecomment-569181205
Can `UTF8` solve all charset problems?
Do we need add a property key to let user provide the charset, just like `aes.key.value`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #3811:
Solve the problem when project's default charset is not utf-8
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #3811: Solve the problem when project's default charset is not utf-8
URL: https://github.com/apache/incubator-shardingsphere/pull/3811
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] minghu-zhang commented on issue #3811:
Solve the problem when project's default charset is not utf-8
Posted by GitBox <gi...@apache.org>.
minghu-zhang commented on issue #3811: Solve the problem when project's default charset is not utf-8
URL: https://github.com/apache/incubator-shardingsphere/pull/3811#issuecomment-569161487
> How about if the original string is not UTF8?
The encryption uses utf-8 encoding, but the decryption does not specify the encoding, and the default system encoding is used. When our system defaults encoding is GBK , the correct result cannot be obtained
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services