You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by "Honoré David N." <dh...@oma.be> on 2004/12/03 10:31:44 UTC

bug in Macro copy

Hello, 

We are working on an opensource Document management system named Dissco 
(http://www.meteo.be/DISSCO/)

Dissco is heavily based on Slide, and working on it, I found a bug in the copy 
Macro.

This bug prevent from copying a "read-only" file.

macro copy is done by the 3 following step.
1) create the new node
2) copying permissions
3) copying content and properties

... and it should be ...
1) create the new node
2) copying content and properties
3) copying permissions

... because, if you copy the permission 
[node, subject=all, action=/actions/write-content, negative=true] before 
copying content, it throw an AccessDeniedException.

You'll find a patch as attachement.
You can also find a testcase ilustrating the bug.


-- 
Honoré David

----------------------------
"They don't make bugs like Bunny anymore." --Olav Mjelde


Re: bug in Macro copy

Posted by Oliver Zeigermann <ol...@gmail.com>.
OK, got that, patch has been applied.

Oliver


On Mon, 6 Dec 2004 09:37:32 +0100, Honoré David N. <dh...@oma.be> wrote:
> The patch simply move the code that copy permissions after the code that copy
> the content and properties.
> 
> Le vendredi 3 Décembre 2004 16:37, Oliver Zeigermann a écrit :
> 
> 
> > Hi,
> >
> > I understand the problem, but I do not understand the patch. Could you
> > explain, please?
> >
> > Oliver
> >
> > On Fri, 3 Dec 2004 10:31:44 +0100, Honoré David N. <dh...@oma.be> wrote:
> > > Hello,
> > >
> > > We are working on an opensource Document management system named Dissco
> > > (http://www.meteo.be/DISSCO/)
> > >
> > > Dissco is heavily based on Slide, and working on it, I found a bug in the
> > > copy Macro.
> > >
> > > This bug prevent from copying a "read-only" file.
> > >
> > > macro copy is done by the 3 following step.
> > > 1) create the new node
> > > 2) copying permissions
> > > 3) copying content and properties
> > >
> > > ... and it should be ...
> > > 1) create the new node
> > > 2) copying content and properties
> > > 3) copying permissions
> > >
> > > ... because, if you copy the permission
> > > [node, subject=all, action=/actions/write-content, negative=true] before
> > > copying content, it throw an AccessDeniedException.
> > >
> > > You'll find a patch as attachement.
> > > You can also find a testcase ilustrating the bug.
> > >
> > > --
> > > Honoré David
> > >
> > > ----------------------------
> > > "They don't make bugs like Bunny anymore." --Olav Mjelde
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> > > For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> 
> --
> Honoré David
> 
> ----------------------------
> "Programming today is a race between software engineers striving to build
> bigger and better idiot-proof programs, and the Universe trying to produce
> bigger and better idiots. So far, the Universe is winning." --Rich Cook
> 
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org


Re: bug in Macro copy

Posted by "Honoré David N." <dh...@oma.be>.
The patch simply move the code that copy permissions after the code that copy 
the content and properties.

Le vendredi 3 Décembre 2004 16:37, Oliver Zeigermann a écrit :
> Hi,
>
> I understand the problem, but I do not understand the patch. Could you
> explain, please?
>
> Oliver
>
> On Fri, 3 Dec 2004 10:31:44 +0100, Honoré David N. <dh...@oma.be> wrote:
> > Hello,
> >
> > We are working on an opensource Document management system named Dissco
> > (http://www.meteo.be/DISSCO/)
> >
> > Dissco is heavily based on Slide, and working on it, I found a bug in the
> > copy Macro.
> >
> > This bug prevent from copying a "read-only" file.
> >
> > macro copy is done by the 3 following step.
> > 1) create the new node
> > 2) copying permissions
> > 3) copying content and properties
> >
> > ... and it should be ...
> > 1) create the new node
> > 2) copying content and properties
> > 3) copying permissions
> >
> > ... because, if you copy the permission
> > [node, subject=all, action=/actions/write-content, negative=true] before
> > copying content, it throw an AccessDeniedException.
> >
> > You'll find a patch as attachement.
> > You can also find a testcase ilustrating the bug.
> >
> > --
> > Honoré David
> >
> > ----------------------------
> > "They don't make bugs like Bunny anymore." --Olav Mjelde
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org

-- 
Honoré David

----------------------------
"Programming today is a race between software engineers striving to build 
bigger and better idiot-proof programs, and the Universe trying to produce 
bigger and better idiots. So far, the Universe is winning." --Rich Cook


---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org


Re: bug in Macro copy

Posted by Oliver Zeigermann <ol...@gmail.com>.
Hi,

I understand the problem, but I do not understand the patch. Could you
explain, please?

Oliver


On Fri, 3 Dec 2004 10:31:44 +0100, Honoré David N. <dh...@oma.be> wrote:
> Hello,
> 
> We are working on an opensource Document management system named Dissco
> (http://www.meteo.be/DISSCO/)
> 
> Dissco is heavily based on Slide, and working on it, I found a bug in the copy
> Macro.
> 
> This bug prevent from copying a "read-only" file.
> 
> macro copy is done by the 3 following step.
> 1) create the new node
> 2) copying permissions
> 3) copying content and properties
> 
> ... and it should be ...
> 1) create the new node
> 2) copying content and properties
> 3) copying permissions
> 
> ... because, if you copy the permission
> [node, subject=all, action=/actions/write-content, negative=true] before
> copying content, it throw an AccessDeniedException.
> 
> You'll find a patch as attachement.
> You can also find a testcase ilustrating the bug.
> 
> --
> Honoré David
> 
> ----------------------------
> "They don't make bugs like Bunny anymore." --Olav Mjelde
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> 
> 
>

---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org