[GitHub] [hive] asinkovits commented on a diff in pull request #3223: HIVE-26155: Create a new connection pool for compaction

[GitBox <gi...@apache.org>]

asinkovits commented on code in PR #3223:
URL: https://github.com/apache/hive/pull/3223#discussion_r856193879


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5836,11 +5835,11 @@ private void removeTxnsFromMinHistoryLevel(Connection dbConn, List<Long> txnids)
     }
   }
 
-  private synchronized static DataSource setupJdbcConnectionPool(Configuration conf, int maxPoolSize, long getConnectionTimeoutMs) {
+  protected synchronized static DataSource setupJdbcConnectionPool(Configuration conf, int maxPoolSize) {

Review Comment:
   I'm not overriding this method, just changed the visibility and removed getConnectionTimeoutMs param as it was not used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org