You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by mikewalch <gi...@git.apache.org> on 2016/09/08 20:38:58 UTC
[GitHub] accumulo pull request #147: ACCUMULO-2884 Removed 'slave' terminology
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/147
ACCUMULO-2884 Removed 'slave' terminology
* Replaced 'slave' with 'tserver' in most cases
* When referring to slave node, used the term 'worker'
* The 'slaves' configuration file is now 'tservers'
* All references to 'slave' were changed except for those in
the design doc for ACCUMULO-378 which discusses replication
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mikewalch/accumulo acc-2884
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #147
----
commit 64f32bcc1c4c97ac2ff3b7ab913a32e4ea6719b8
Author: Mike Walch <mw...@apache.org>
Date: 2016-09-08T19:27:54Z
ACCUMULO-2884 Removed 'slave' terminology
* Replaced 'slave' with 'tserver' in most cases
* When referring to slave node, used the term 'worker'
* The 'slaves' configuration file is now 'tservers'
* All references to 'slave' were changed except for those in
the design doc for ACCUMULO-378 which discusses replication
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2844 Removed 'slave' terminology
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/147
> First, fail if 'slaves' file exists and tell user to rename file to 'tservers' or remove 'slaves' if both exist. This will prevent users from having both files.
Next, fail if 'tservers' does not exist
+1 on that plan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2884 Removed 'slave' terminology
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
Below are the errors that are printed if `tservers` file is missing.
```
Starting monitor on localhost
Starting tablet servers ...egrep: /install/accumulo-2.0.0-SNAPSHOT/conf/tservers: No such file or directory
done
2016-09-08 15:38:59,896 [util.NativeCodeLoader] WARN : Unable to load native-hadoop library for your platform... using builtin-java classes where applicable
2016-09-08 15:39:01,574 [server.Accumulo] INFO : Attempting to talk to zookeeper
2016-09-08 15:39:01,772 [server.Accumulo] INFO : ZooKeeper connected and initialized, attempting to talk to HDFS
2016-09-08 15:39:01,960 [server.Accumulo] INFO : Connected to HDFS
/install/accumulo-2.0.0-SNAPSHOT/bin/start-daemon.sh: line 67: /install/accumulo-2.0.0-SNAPSHOT/conf/tservers: No such file or directory
Starting master on localhost:
/install/accumulo-2.0.0-SNAPSHOT/bin/start-daemon.sh: line 67: /install/accumulo-2.0.0-SNAPSHOT/conf/tservers: No such file or directory
Starting gc on localhost
/install/accumulo-2.0.0-SNAPSHOT/bin/start-daemon.sh: line 67: /install/accumulo-2.0.0-SNAPSHOT/conf/tservers: No such file or directory
Starting tracer on localhost
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2884 Removed 'slave' terminology
Posted by dimaspivak <gi...@git.apache.org>.
Github user dimaspivak commented on the issue:
https://github.com/apache/accumulo/pull/147
Should probably rename this PR; it's ACCUMULO-2844, not ACCUMULO-2884.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2884 Removed 'slave' terminology
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
For testing, I built the Accumulo tarball and was able to start Accumulo successfully using the scripts. I started Accumulo without the `tservers` and error messages were printed that the 'tservers' file could not be found. I did not do any testing of the test scripts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2844 Removed 'slave' terminology
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
Added checks to scripts in c182f806daa48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2884 Removed 'slave' terminology
Posted by keith-turner <gi...@git.apache.org>.
Github user keith-turner commented on the issue:
https://github.com/apache/accumulo/pull/147
> Thoughts on how to address compatibility from the 1.x slaves file?
At the very least we want clear error messages is the new file is not found, which we have. Do not want users to waste a lot of time trying to figure out why its not starting.
> Do we want to allow fall-back to ease upgrades?
-0. Would be slightly helpful in the case of automation. I think w/ the error message about a missing tservers file, most users will quickly figure out what they need to do. If we did do it may want to error in the case where tservers and slaves file both exist. In case where only slaves files exist, could print an error message saying its deprecated and should be renamed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request #147: ACCUMULO-2844 Removed 'slave' terminology
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2884 Removed 'slave' terminology
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/147
> Below are the errors that are printed if `tservers` file is missing.
Thoughts on how to address compatibility from the 1.x `slaves` file? Do we want to allow fall-back to ease upgrades? I would think so, although it looks like it would require changes in multiple places which is annoying.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2844 Removed 'slave' terminology
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
> This sounds OK to me. We have a bit more leeway with a "real" major release than I'm used to. I think I would be OK with error'ing out of the script in the case when only the slaves file exists instead of just printing a message (catch it as early as possible and push people to rename now instead of delaying).
I like this approach. I don't like falling back to 'slaves' file if 'tservers' does not exist as all scripts that depend on 'tservers' need to do this. A proper error message is sufficient. It's an easy fix. I will add the following checks to the script and update the PR:
* First, fail if 'slaves' file exists and tell user to rename file to 'tservers' or remove 'slaves' if both exist. This will prevent users from having both files.
* Next, fail if 'tservers' does not exist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2844 Removed 'slave' terminology
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/147
> > Do we want to allow fall-back to ease upgrades?
> -0. Would be slightly helpful in the case of automation. I think w/ the error message about a missing tservers file, most users will quickly figure out what they need to do. If we did do it may want to error in the case where tservers and slaves file both exist. In case where only slaves files exist, could print an error message saying its deprecated and should be renamed.
This sounds OK to me. We have a bit more leeway with a "real" major release than I'm used to. I think I would be OK with error'ing out of the script in the case when only the `slaves` file exists instead of just printing a message (catch it as early as possible and push people to rename now instead of delaying).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2884 Removed 'slave' terminology
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the issue:
https://github.com/apache/accumulo/pull/147
> Should probably rename this PR; it's ACCUMULO-2844, not ACCUMULO-2884.
Nice catch @dimaspivak. Will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo issue #147: ACCUMULO-2844 Removed 'slave' terminology
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on the issue:
https://github.com/apache/accumulo/pull/147
Created ACCUMULO-4449 for this "subset" of changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---