You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2023/07/12 14:49:39 UTC
[plc4x] 02/02: test(plc4go/cbus): improve assertion
This is an automated email from the ASF dual-hosted git repository.
sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git
commit 8968760a27b0f99315c39f6c5af9bb49ddc02f02
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Wed Jul 12 16:18:02 2023 +0200
test(plc4go/cbus): improve assertion
---
plc4go/internal/cbus/Browser_test.go | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/plc4go/internal/cbus/Browser_test.go b/plc4go/internal/cbus/Browser_test.go
index 0309f1f0b3..87fb9dfaa7 100644
--- a/plc4go/internal/cbus/Browser_test.go
+++ b/plc4go/internal/cbus/Browser_test.go
@@ -160,9 +160,7 @@ func TestBrowser_BrowseQuery(t *testing.T) {
assert.NoError(t, driver.Close())
})
connectionConnectResult := <-driver.GetConnection(transportUrl, map[string]transports.Transport{"test": transport}, map[string][]string{})
- if err := connectionConnectResult.GetErr(); err != nil {
- t.Fatal(err)
- }
+ require.NoError(t, connectionConnectResult.GetErr())
fields.connection = connectionConnectResult.GetConnection()
t.Cleanup(func() {
timer := time.NewTimer(10 * time.Second)
@@ -319,10 +317,7 @@ func TestBrowser_browseUnitInfo(t *testing.T) {
assert.NoError(t, driver.Close())
})
connectionConnectResult := <-driver.GetConnection(transportUrl, map[string]transports.Transport{"test": transport}, map[string][]string{})
- if err := connectionConnectResult.GetErr(); err != nil {
- t.Error(err)
- t.FailNow()
- }
+ require.NoError(t, connectionConnectResult.GetErr())
fields.connection = connectionConnectResult.GetConnection()
t.Cleanup(func() {
timer := time.NewTimer(10 * time.Second)
@@ -595,10 +590,7 @@ func TestBrowser_getInstalledUnitAddressBytes(t *testing.T) {
assert.NoError(t, driver.Close())
})
connectionConnectResult := <-driver.GetConnection(transportUrl, map[string]transports.Transport{"test": transport}, map[string][]string{})
- if err := connectionConnectResult.GetErr(); err != nil {
- t.Error(err)
- t.FailNow()
- }
+ require.NoError(t, connectionConnectResult.GetErr())
fields.connection = connectionConnectResult.GetConnection()
t.Cleanup(func() {
timer := time.NewTimer(6 * time.Second)