[GitHub] [trafficcontrol] traeak commented on a diff in pull request #7719: add automatic self-healing when using slice plugin to t3c

["traeak (via GitHub)" <gi...@apache.org>]

traeak commented on code in PR #7719:
URL: https://github.com/apache/trafficcontrol/pull/7719#discussion_r1301918485


##########
lib/go-atscfg/remapdotconfig_test.go:
##########
@@ -1687,6 +1691,9 @@ func TestMakeRemapDotConfigMidSlicePluginRangeRequestHandling(t *testing.T) {
 
 	txt = strings.TrimSpace(txt)
 
+	if !strings.Contains(txt, "@pparam=--consider-ims") {
+		t.Fatalf("expected '--consider-ims' param with 'cache_range_requests.so' when using slice plugin to enable self healing, actual: %s", txt)

Review Comment:
   I suspect you left this in as "Fatalf on accident.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org