You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/26 12:47:27 UTC
[GitHub] [arrow-rs] alamb opened a new issue #181: Adopt a MSRV policy
alamb opened a new issue #181:
URL: https://github.com/apache/arrow-rs/issues/181
*Note*: migrated from original JIRA: https://issues.apache.org/jira/browse/ARROW-11605
With all our crates now supporting stable Rust, we can decide on a Minimum Supported Rust Version, so that we don't introduce breakage to people relying on older Rust versions.
We could:
* Determine what the earliest Rust version that compiles is (at least 1.39 due to async in DF)
* Use this version in CI
* Decide on, and document, a policy for how we update versions
This might mean that when there's fresh new changes landing in Stable, we'd likely hold off on them until those changes meet our MSRV.
Thoughts [~Dandandan] [~alamb] [~jorgecarleitao] [~andygrove] [~paddyhoran] [~sunchao]?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #181: Adopt a MSRV policy
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #181:
URL: https://github.com/apache/arrow-rs/issues/181#issuecomment-882540757
Thanks @dbr -- what would work best for you? Only changing the required rust version on major updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #181: Adopt a MSRV policy
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #181:
URL: https://github.com/apache/arrow-rs/issues/181#issuecomment-882540757
Thanks @dbr -- what would work best for you? Only changing the required rust version on major updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] dbr commented on issue #181: Adopt a MSRV policy
Posted by GitBox <gi...@apache.org>.
dbr commented on issue #181:
URL: https://github.com/apache/arrow-rs/issues/181#issuecomment-882175409
This would be nice to have - for example from arrow 4.2 to 4.3 the required Rust version jumped from 1.51 to 1.52 (as noted in #456), but wasn't mentioned in release notes, and was a little surprising in a point release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #181: Adopt a MSRV policy
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #181:
URL: https://github.com/apache/arrow-rs/issues/181#issuecomment-882540757
Thanks @dbr -- what would work best for you? Only changing the required rust version on major updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #181: Adopt a MSRV policy
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #181:
URL: https://github.com/apache/arrow-rs/issues/181#issuecomment-826807160
Comment from Andrew Lamb(alamb) @ 2021-02-18T10:40:55.550+0000:
<pre>[~nevi_me] I don't have any well formed thoughts here -- it sounds like a reasonable idea to me. </pre>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #181: Adopt a MSRV policy
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #181:
URL: https://github.com/apache/arrow-rs/issues/181#issuecomment-885214952
@dbr -- got it -- as it turns out I was somewhat surprised by the min change too (I didn't realize that something we backported used a new API in rust 1.53).
In order to properly implement such a version policy, we would probably need to pin the rust version used in the arrow-rs crate's CI system (otherwise we effectively get the latest rust whenever it is released, and we often scramble to fix new clippy lints and what not)
Feel free to submit a PR if you have a moment -- maybe using something like https://github.com/influxdata/influxdb_iox/blob/main/rust-toolchain.toml to pin to rust 1.53?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] dbr commented on issue #181: Adopt a MSRV policy
Posted by GitBox <gi...@apache.org>.
dbr commented on issue #181:
URL: https://github.com/apache/arrow-rs/issues/181#issuecomment-883873802
Practically, as long the requirement changes are noted in the `CHANGELOG.md`, I'd be happy!
The main inconvenience with the 4.3 release to me was just I wasn't sure what had happened - I ran `cargo update` and got a strange error, and the changelog didn't mention anything significant. Had I not found #456 it would have taken a bit of poking around to realize exactly what happened
I think it makes more logical sense for minimum-Rust-version changes to be major bumps (since the change makes previously compiling code start erroring, practically the same as any other breaking change), but I know there is a lot of debate around this and I don't have any especially strong opinions on it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org