You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2016/10/21 21:57:28 UTC
[Impala-ASF-CR] IMPALA-4295: 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug
Jim Apple has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4784
Change subject: IMPALA-4295: 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug
......................................................................
IMPALA-4295: 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug
This bug was latent before that commit; XFAILing now to green the
tests.
Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
---
M tests/custom_cluster/test_client_ssl.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/4784/1
--
To view, visit http://gerrit.cloudera.org:8080/4784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
[Impala-ASF-CR] IMPALA-4295: XFAIL wildcard SSL test
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4295: XFAIL wildcard SSL test
......................................................................
IMPALA-4295: XFAIL wildcard SSL test
commit 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug (one
that was latent before the commit). I am XFAILing this now just to
green the build; IMPALA-4295 can be resolved when this issue is fixed
and not just XFAILed.
Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
Reviewed-on: http://gerrit.cloudera.org:8080/4784
Reviewed-by: Jim Apple <jb...@cloudera.com>
Tested-by: Internal Jenkins
---
M tests/custom_cluster/test_client_ssl.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jim Apple: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4295: 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4295: 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4784/1//COMMIT_MSG
Commit Message:
PS1, Line 7: 9f61397fc4d638aa78b37db2cd5b9c35b6deed94
Prefer "xfail wildcard SSL test", and add this commentary to the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/4784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4295: XFAIL wildcard SSL test
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4295: XFAIL wildcard SSL test
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4295: XFAIL wildcard SSL test
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4784
to look at the new patch set (#2).
Change subject: IMPALA-4295: XFAIL wildcard SSL test
......................................................................
IMPALA-4295: XFAIL wildcard SSL test
commit 9f61397fc4d638aa78b37db2cd5b9c35b6deed94 exposed a bug (one
that was latent before the commit). I am XFAILing this now just to
green the build; IMPALA-4295 can be resolved when this issue is fixed
and not just XFAILed.
Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
---
M tests/custom_cluster/test_client_ssl.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/4784/2
--
To view, visit http://gerrit.cloudera.org:8080/4784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4295: XFAIL wildcard SSL test
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-4295: XFAIL wildcard SSL test
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Carry +2
http://gerrit.cloudera.org:8080/#/c/4784/1//COMMIT_MSG
Commit Message:
PS1, Line 7: XFAIL wildcard SSL test
> Prefer "xfail wildcard SSL test", and add this commentary to the commit mes
Done
--
To view, visit http://gerrit.cloudera.org:8080/4784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie809c6c6c967447d527927ebbc6b110095e7320a
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes