You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2017/01/07 11:47:05 UTC

Re: Review Request 52666: Added support for `docker inspect image` in docker containerizer.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52666/
-----------------------------------------------------------

(Updated \u4e00\u6708 7, 2017, 11:47 a.m.)


Review request for mesos, Benjamin Mahler and Kevin Klues.


Changes
-------

Rebase


Bugs: MESOS-5967
    https://issues.apache.org/jira/browse/MESOS-5967


Repository: mesos


Description
-------

Added support for `docker inspect image` in docker containerizer.


Diffs (updated)
-----

  src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
  src/docker/docker.cpp 472cb1b4dc2b0ac65721c732fca8ec70a7470f47 
  src/tests/containerizer/docker_tests.cpp 9667d434486c1832f180a297a39a3d5dae6a26bd 

Diff: https://reviews.apache.org/r/52666/diff/


Testing
-------

make
make check

```
./bin/mesos-tests.sh --gtest_filter="DockerTest.ROOT_DOCKER_Inspect*"
[==========] Running 2 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 2 tests from DockerTest
[ RUN      ] DockerTest.ROOT_DOCKER_InspectExistImage
[       OK ] DockerTest.ROOT_DOCKER_InspectExistImage (6769 ms)
[ RUN      ] DockerTest.ROOT_DOCKER_InspectNonExistImage
[       OK ] DockerTest.ROOT_DOCKER_InspectNonExistImage (314 ms)
[----------] 2 tests from DockerTest (7083 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 1 test case ran. (7090 ms total)
[  PASSED  ] 2 tests.
```


Thanks,

Guangya Liu