[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6660: Flink: Support writes to branches in FlinkSink

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6660:
URL: https://github.com/apache/iceberg/pull/6660#discussion_r1087212028


##########
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/SimpleDataUtil.java:
##########
@@ -284,10 +303,23 @@ public static void assertTableRecords(Table table, List<Record> expected) throws
     }
   }
 
+  public static Snapshot latestSnapshot(Table table, String branch) {

Review Comment:
   shouldn't this always be `table.snapshot(branch)`? Why we need to handle main branch specially?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org