You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by atrigent <gi...@git.apache.org> on 2017/07/04 03:54:52 UTC

[GitHub] spark pull request #17832: [SPARK-20557][SQL] Support for db column type TIM...

Github user atrigent commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17832#discussion_r125385324
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala ---
    @@ -223,6 +223,9 @@ object JdbcUtils extends Logging {
           case java.sql.Types.STRUCT        => StringType
           case java.sql.Types.TIME          => TimestampType
           case java.sql.Types.TIMESTAMP     => TimestampType
    +      case java.sql.Types.TIMESTAMP_WITH_TIMEZONE
    +                                        => TimestampType
    +      case -101                         => TimestampType
    --- End diff --
    
    Why was this `-101` thing put here instead of in the Oracle dialect?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org