[incubator-pinot] branch master updated: [TE] rootcause - prevent metric selection change on dimension table tab change (#3536)

[ap...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 79f83e9  [TE] rootcause - prevent metric selection change on dimension table tab change (#3536)
79f83e9 is described below

commit 79f83e9a3bd9f017f36f20131a90b850bef84983
Author: Alexander Pucher <ap...@linkedin.com>
AuthorDate: Wed Nov 21 10:53:31 2018 -0800

    [TE] rootcause - prevent metric selection change on dimension table tab change (#3536)
---
 .../app/pods/components/rootcause-dimensions-table/component.js  | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
index 0e5969e..a589d06 100644
--- a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
+++ b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-dimensions-table/component.js
@@ -165,7 +165,14 @@ export default Component.extend({
    * Keeps track of items that are selected in the table
    * @type {Array}
    */
-  preselectedItems: [], // FIXME: this is broken across all of RCA and works by accident only
+  preselectedItems: computed({
+    get () {
+      return [];
+    },
+    set () {
+      // ignore
+    }
+  }),
 
   /**
    * Sums all values for a given dimension name


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org