[jira] [Commented] (SOLR-2950) QueryElevationComponent needlessly looks up document ids

["Yonik Seeley (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163661#comment-13163661 ] 

Yonik Seeley commented on SOLR-2950:
------------------------------------

Instead of doing everything on inform (which isn't great for NRT), we should just do it on-demand in the comparator in setNextReader() for only those uniqueKeys that were boosted)

We could cache the uniqueKey -> docid across queries, but not sure it's worth it at this point (assuming at most a handful of docs are boosted per-query).  And if we did want some sort of uniqueKey -> docid cache it would make most sense to be an internal cache in SolrIndexSearcher, not private to the QEC.
                
> QueryElevationComponent needlessly looks up document ids
> --------------------------------------------------------
>
>                 Key: SOLR-2950
>                 URL: https://issues.apache.org/jira/browse/SOLR-2950
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Priority: Minor
>             Fix For: 3.6, 4.0
>
>
> The QueryElevationComponent needlessly instantiates a FieldCache and does look ups in it for every document.  If we flipped things around a bit and got Lucene internal doc ids on inform() we could then simply do a much smaller and faster lookup during the sort.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org