You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by jo...@apache.org on 2021/05/07 23:52:19 UTC
[impala] 01/02: IMPALA-10683: Skip test 'test_double_precision' for
non-HDFS test env
This is an automated email from the ASF dual-hosted git repository.
joemcdonnell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 9253e0a9e7751a471ddfde754767ca8f56b14ec4
Author: Amogh Margoor <am...@cloudera.com>
AuthorDate: Tue May 4 02:48:26 2021 -0700
IMPALA-10683: Skip test 'test_double_precision' for non-HDFS test env
TestHdfsParquetTableWriter.test_double_parser uses Hive statement.
IMPALA-9365 describes why HS2 is not started on non-HDFS test env
and therefore we need to skip this test for such test environments.
Hive statement is being used as Impala's result are converted
by python to string. In both HS2 and beewax, it only handles float
precision uptil 16 decimal digits and test needs 17.
Change-Id: I1a3225ba563ec4d0514b489c3a1daf8291ca1445
Reviewed-on: http://gerrit.cloudera.org:8080/17397
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
tests/query_test/test_insert_parquet.py | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tests/query_test/test_insert_parquet.py b/tests/query_test/test_insert_parquet.py
index 5faf31b..1a050e6 100644
--- a/tests/query_test/test_insert_parquet.py
+++ b/tests/query_test/test_insert_parquet.py
@@ -533,6 +533,17 @@ class TestHdfsParquetTableWriter(ImpalaTestSuite):
self._ctas_and_check_int64_timestamps(vector, unique_database, tmpdir, "micros")
self._ctas_and_check_int64_timestamps(vector, unique_database, tmpdir, "nanos")
+ # Skip test for non-HDFS environment as it uses Hive statement.
+ # Hive statement is being used as Impala's result are converted
+ # by python to string. In both HS2 and beewax, it only handles float
+ # precision uptil 16 decimal digits and test needs 17.
+ # IMPALA-9365 describes why HS2 is not started on non-HDFS test env.
+ @SkipIfS3.hive
+ @SkipIfGCS.hive
+ @SkipIfABFS.hive
+ @SkipIfADLS.hive
+ @SkipIfIsilon.hive
+ @SkipIfLocal.hive
def test_double_precision(self, vector, unique_database):
# IMPALA-10654: Test inserting double into Parquet table retains the precision.
src_tbl = "{0}.{1}".format(unique_database, "i10654_parquet")