[GitHub] [shardingsphere] csonezp commented on pull request #18893: listen on specified addresses

[GitBox <gi...@apache.org>]

csonezp commented on PR #18893:
URL: https://github.com/apache/shardingsphere/pull/18893#issuecomment-1177462460

   > Hi @csonezp I tried your branch and I found a problem:
   > 
   > I wrote an absolute path of config directory:
   > 
   > ```shell
   > bin/start.sh 33306 /home/wuweijie/dev/shardingsphere/proxy/master/mysql/conf
   > ```
   > 
   > But the absolute path was prefixed with `DEPLOY_DIR`
   > 
   > ```
   > $ tail logs/stdout.log                                                                                                                                                                                                                                                                                             [16:44:09]
   >         at org.apache.shardingsphere.proxy.backend.config.ProxyConfigurationLoader.load(ProxyConfigurationLoader.java:60)
   >         at org.apache.shardingsphere.proxy.Bootstrap.main(Bootstrap.java:49)
   > Exception in thread "main" java.io.FileNotFoundException: /home/wuweijie/projects/shardingsphere/shardingsphere-distribution/shardingsphere-proxy-distribution/target/apache-shardingsphere-5.1.3-SNAPSHOT-shardingsphere-proxy-bin/home/wuweijie/dev/shardingsphere/proxy/master/mysql/conf/server.yaml (No such file or directory)
   >         at java.base/java.io.FileInputStream.open0(Native Method)
   >         at java.base/java.io.FileInputStream.open(FileInputStream.java:216)
   >         at java.base/java.io.FileInputStream.<init>(FileInputStream.java:157)
   >         at org.apache.shardingsphere.infra.yaml.engine.YamlEngine.unmarshal(YamlEngine.java:54)
   >         at org.apache.shardingsphere.proxy.backend.config.ProxyConfigurationLoader.loadServerConfiguration(ProxyConfigurationLoader.java:74)
   >         at org.apache.shardingsphere.proxy.backend.config.ProxyConfigurationLoader.load(ProxyConfigurationLoader.java:60)
   >         at org.apache.shardingsphere.proxy.Bootstrap.main(Bootstrap.java:49)
   > ```
   
   @TeslaCN my bad, I will go through the script and write a test report. Is there a way to test the script file in the source code?
   
   And I found a bug in master branch: if user wrote an absolute path, the script  will merge  the absolute path and ${DEPLOY_DIR},  and then add the result to ${CLASS_PATH}. Like this:
   ![image](https://user-images.githubusercontent.com/3190994/177762773-1bbfd115-68bb-428a-b6b3-818fa817e392.png)
   should i fix it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org