You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/23 09:57:09 UTC

[GitHub] [pulsar] congbobo184 commented on a diff in pull request #19014: [fix] [doc] Fix outdated java-doc of rate limiter

congbobo184 commented on code in PR #19014:
URL: https://github.com/apache/pulsar/pull/19014#discussion_r1056197745


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/DispatchRateLimiter.java:
##########
@@ -99,10 +99,10 @@ public long getAvailableDispatchRateLimitOnByte() {
      */
     public boolean tryDispatchPermit(long msgPermits, long bytePermits) {
         boolean acquiredMsgPermit = msgPermits <= 0 || dispatchRateLimiterOnMessage == null
-        // acquiring permits must be < configured msg-rate;
+        // In dispatch mode, acquiring permits can be larger than configured msg-rate.

Review Comment:
   dispatch mode represents what? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org