Re: [PR] Add HttpClient5 sampler implementation with HTTP/2 support [jmeter]

["milamberspace (via GitHub)" <gi...@apache.org>]

milamberspace commented on code in PR #6742:
URL: https://github.com/apache/jmeter/pull/6742#discussion_r3749316185


##########
src/bom-thirdparty/build.gradle.kts:
##########
@@ -107,6 +107,8 @@ dependencies {
             because("User might still rely on commons-text")
         }
         api("org.apache.httpcomponents.client5:httpclient5:5.5.1")

Review Comment:
   Since `HTTPHC5Impl` (this PR) exercises HttpClient5's async TLS upgrade path for HTTP/2, worth bumping both of these before merge:
   
   - `httpclient5`: `5.5.1` → **`5.6.4`** — fixes "SSL parameter application in the async TLS upgrade strategy" ([release notes](https://downloads.apache.org/httpcomponents/httpclient/RELEASE_NOTES-5.6.x.txt))
   - `httpcore5` / `httpcore5-h2`: `5.3.4` → **`5.4.3`** — the version `httpclient5:5.6.4` is actually built and tested against (per its parent POM's `httpcore.version` property), so bumping only `httpclient5` and leaving `httpcore5` at `5.3.4` would be an incoherent pairing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org