[GitHub] [apisix] bisakhmondal commented on a change in pull request #6103: chore: streamline error checking process

[GitBox <gi...@apache.org>]

bisakhmondal commented on a change in pull request #6103:
URL: https://github.com/apache/apisix/pull/6103#discussion_r785299031



##########
File path: apisix/plugins/openid-connect.lua
##########
@@ -293,30 +293,28 @@ function _M.rewrite(plugin_conf, ctx)
         -- the configured redirect URI after successful authentication.
         response, err = openidc.authenticate(conf)
 
-        if err then
+        if not response then

Review comment:
       Thanks. Updated

##########
File path: t/plugin/basic-auth.t
##########
@@ -398,7 +398,7 @@ GET /t
 
 
 
-=== TEST 15: enable basic auth plugin using admin api, set hide_credentials = true
+=== TEST 18: enable basic auth plugin using admin api, set hide_credentials = true

Review comment:
       Done. Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org