You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/04 14:50:09 UTC
[GitHub] [superset] geido opened a new pull request, #19517: chore: Enhance ReactChord style with theme vars
geido opened a new pull request, #19517:
URL: https://github.com/apache/superset/pull/19517
### SUMMARY
It enhances the ReactChord component style with theme vars.
### BEFORE
https://user-images.githubusercontent.com/60598000/161570315-6774f76a-f6de-412f-9b1b-b3d5df79e5b9.mp4
### AFTER
### TESTING INSTRUCTIONS
1. No observable visual changes. Opacity might be slightly different to match the theme vars.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #19517: chore: Enhance ReactChord style with theme vars
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #19517:
URL: https://github.com/apache/superset/pull/19517#discussion_r842011583
##########
superset-frontend/plugins/legacy-plugin-chart-chord/src/ReactChord.jsx:
##########
@@ -39,18 +39,20 @@ Chord.propTypes = {
};
export default styled(Chord)`
- .superset-legacy-chart-chord svg #circle circle {
- fill: none;
- pointer-events: all;
- }
- .superset-legacy-chart-chord svg .group path {
- fill-opacity: 0.6;
- }
- .superset-legacy-chart-chord svg path.chord {
- stroke: #000;
- stroke-width: 0.25px;
- }
- .superset-legacy-chart-chord svg #circle:hover path.fade {
- opacity: 0.2;
- }
+ ${({ theme }) => `
+ .superset-legacy-chart-chord svg #circle circle {
+ fill: none;
+ pointer-events: all;
+ }
+ .superset-legacy-chart-chord svg .group path {
+ fill-opacity: ${theme.opacity.mediumHeavy};
+ }
+ .superset-legacy-chart-chord svg path.chord {
+ stroke: ${theme.colors.grayscale.dark2};
+ stroke-width: 0.25px;
+ }
+ .superset-legacy-chart-chord svg #circle:hover path.fade {
+ opacity: ${theme.opacity.mediumLight};
Review Comment:
I think 10% opacity looked better than 35% when hovering.
```suggestion
opacity: ${theme.opacity.light};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #19517: chore: Enhance ReactChord style with theme vars
Posted by GitBox <gi...@apache.org>.
geido merged PR #19517:
URL: https://github.com/apache/superset/pull/19517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19517: chore: Enhance ReactChord style with theme vars
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19517:
URL: https://github.com/apache/superset/pull/19517#issuecomment-1089116573
# [Codecov](https://codecov.io/gh/apache/superset/pull/19517?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19517](https://codecov.io/gh/apache/superset/pull/19517?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cb3bb66) into [master](https://codecov.io/gh/apache/superset/commit/0de03c4b34fd13d4f751710277ede3ca0c9b1033?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0de03c4) will **decrease** coverage by `0.00%`.
> The diff coverage is `69.36%`.
> :exclamation: Current head cb3bb66 differs from pull request most recent head 40fef59. Consider uploading reports for the commit 40fef59 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19517 +/- ##
==========================================
- Coverage 66.59% 66.59% -0.01%
==========================================
Files 1678 1682 +4
Lines 64242 64294 +52
Branches 6539 6554 +15
==========================================
+ Hits 42784 42817 +33
- Misses 19763 19776 +13
- Partials 1695 1701 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.36% <67.92%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19517?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ugins/legacy-plugin-chart-chord/src/ReactChord.jsx](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWNob3JkL3NyYy9SZWFjdENob3JkLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...allel-coordinates/src/ReactParallelCoordinates.jsx](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcmFsbGVsLWNvb3JkaW5hdGVzL3NyYy9SZWFjdFBhcmFsbGVsQ29vcmRpbmF0ZXMuanN4) | `0.00% <0.00%> (ø)` | |
| [...legacy-plugin-chart-sunburst/src/ReactSunburst.jsx](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXN1bmJ1cnN0L3NyYy9SZWFjdFN1bmJ1cnN0LmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXN1bmJ1cnN0L3NyYy9TdW5idXJzdC5qcw==) | `0.00% <ø> (ø)` | |
| [...s/legacy-plugin-chart-treemap/src/ReactTreemap.jsx](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXRyZWVtYXAvc3JjL1JlYWN0VHJlZW1hcC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...plugins/legacy-plugin-chart-treemap/src/Treemap.js](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXRyZWVtYXAvc3JjL1RyZWVtYXAuanM=) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <ø> (ø)` | |
| [...d/src/explore/components/DatasourcePanel/index.tsx](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwvaW5kZXgudHN4) | `69.23% <ø> (ø)` | |
| [...end/src/explore/components/RowCountLabel/index.tsx](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Sb3dDb3VudExhYmVsL2luZGV4LnRzeA==) | `88.88% <ø> (ø)` | |
| [superset-frontend/src/profile/App.tsx](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLnRzeA==) | `0.00% <ø> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/superset/pull/19517/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19517?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19517?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0de03c4...40fef59](https://codecov.io/gh/apache/superset/pull/19517?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org