[GitHub] [airflow] jedcunningham commented on a diff in pull request #25484: HostAliases support for scheduler and webserver

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #25484:
URL: https://github.com/apache/airflow/pull/25484#discussion_r937094291


##########
tests/charts/test_scheduler.py:
##########
@@ -115,6 +115,20 @@ def test_should_add_extra_volume_and_extra_volume_mount(self):
             "spec.template.spec.containers[0].volumeMounts[*].name", docs[0]
         )
 
+    def test_scheduler_host_aliases(self):
+        docs = render_chart(
+            values={
+                "executor": "CeleryExecutor",

Review Comment:
   ```suggestion
   ```
   
   Don't need that, it's the default.



##########
chart/values.schema.json:
##########
@@ -1802,6 +1802,28 @@
                         "$ref": "#/definitions/io.k8s.api.core.v1.Toleration"
                     }
                 },
+                "hostAliases": {
+                    "description": "Specify HostAliases for scheduler.",
+                    "items": {
+                        "$ref": "#/definitions/io.k8s.api.core.v1.HostAlias"
+                    },
+                    "type": "array",
+                    "default": [],
+                    "examples": [
+                        {
+                            "ip": "127.0.0.2",
+                            "hostnames": [
+                                "test.hostname.one"
+                            ]
+                        },
+                        {
+                            "ip": "127.0.0.3",
+                            "hostnames": [
+                                "test.hostname.two"
+                            ]

Review Comment:
   ```suggestion
   ```
   
   Here as well.



##########
chart/values.yaml:
##########
@@ -685,6 +685,16 @@ scheduler:
   #      weight: 100
   tolerations: []
   topologySpreadConstraints: []
+  # hostAliases to use in scheduler pods.
+  # See:
+  # https://kubernetes.io/docs/concepts/services-networking/add-entries-to-pod-etc-hosts-with-host-aliases/

Review Comment:
   I think we can get away without these.
   
   ```suggestion
   ```



##########
chart/values.yaml:
##########
@@ -685,6 +685,16 @@ scheduler:
   #      weight: 100
   tolerations: []
   topologySpreadConstraints: []
+  # hostAliases to use in scheduler pods.
+  # See:
+  # https://kubernetes.io/docs/concepts/services-networking/add-entries-to-pod-etc-hosts-with-host-aliases/
+  hostAliases: []
+  # - ip: "127.0.0.2"
+  #   hostnames:
+  #   - "test.hostname.one"
+  # - ip: "127.0.0.3"
+  #   hostnames:
+  #   - "test.hostname.two"

Review Comment:
   ```suggestion
   ```
   
   I think one example should be sufficient?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org