You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/17 18:33:28 UTC
[GitHub] [airflow] ad-m opened a new issue #9351: Consider renaming master branch to something less offensive
ad-m opened a new issue #9351:
URL: https://github.com/apache/airflow/issues/9351
As a long-time lover of project collaborators, I would like to propose...
Master is not a good term for the main branch, I'd say its high time to consider renaming this to something like main or edge.
According Apache CoC:
> Whether we are participating as professionals or volunteers, we value professionalism in all interactions, and take responsibility for our own speech. Be kind to others. Do not insult or put down other participants. Harassment and other exclusionary behaviour are not acceptable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647409405
@ashb @potiuk who can make the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647504692
Indeed we have a super-easy way to build documentation - simply run './breeze build-documentation' and all should happen automatically. I would love to hear what problems you experience with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647521782
We need to be extra cautious and think this through and maybe first try any automation we think of on a dummy repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk removed a comment on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
potiuk removed a comment on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647504692
Indeed we have a super-easy way to build documentation - simply run './breeze build-documentation' and all should happen automatically. I would love to hear what problems you experience with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-661717449
Yep. GitHub suggest to wait a bit as they are working on support to
seamlessly change the branch name.
I think considering the impact it might have on our opened PRs I think it
is a wise thing to wait until this support is ready (even though I'd love
to change it now).
J.
wt., 21 lip 2020, 10:28 użytkownik Tomek Urbaszek <no...@github.com>
napisał:
> https://github.com/github/renaming
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/airflow/issues/9351#issuecomment-661714332>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAERMIZWSZLKVUR7KUUJJCDR4VGSPANCNFSM4OA3QYTA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
feluelle commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-645551579
`develop` 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647416139
@turbaszek This can be more problematic than we expected. See: https://apache-airflow.slack.com/archives/CCPRP7943/p1592582878155700
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] leahecole commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
leahecole commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-645652241
develop or main seem great to me, and if develop makes more sense with Airflow, seems like a great idea to me :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647495823
Oh I have missed it, thanks @mik-laj ! Btw. having github issues now, shouldn't we encourage discussion here instead of slack (especially if ticket exists) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647542295
Agree. While I am all for changing - I think we can wreak havoc by haste changes here.
An Idea: Why don't we continue working on 2.0 in master and once we start 2.1 work we can create "development" branch. Rather than switching to master in a big-bang we will simply ask everyone to move their PR to "development" as base if they want to get them merged. This way we can do it gradually and naturally. And it's a good opportunity for a "clean" start for 2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-645550591
@ad-m I agree with this proposal. Personally I would opt for `develop` or `main`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-645557221
> `main` seems to be GitHubs new default
That's true, however, I would say that in our case the `develop` sounds like a better approach as we have "version-branches".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-645554250
`main` seems to be GitHubs new default
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
ashb closed issue #9351:
URL: https://github.com/apache/airflow/issues/9351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-645550763
@ashb @aijamalnk @leahecole @potiuk @kaxil @mik-laj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-794460396
Yes to this! And I'm starting to work on it now. I'm going to close this issue for #12982 which has a concrete plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647542295
Agree. While I am all for changing - I think we can wreak havoc by haste changes here.
An Idea: Why don't we continue working on 2.0 in master and once we start 2.1 work we can create "development" branch. Rather than switching to master in a big-bang we will simply ask everyone to move their PR to "development" for their PRs if they want to get them merged. This way we can do it gradually and naturally. And it's a good opportunity for a "clean" start for 2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647542295
Agree. While I am all for changing - I think we can wreak havoc by haste changes here.
An Idea: Why don't we continue working on 2.0 in master and once we start 2.1 work we can create "development" branch and rather than switching to master immediately we will simply ask everyone to move their PR to "development" for their PRs if they want to get it merged. This way we can do it gradually and naturally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ad-m commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
ad-m commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647516608
@turbaszek , yes, according to Apache CoC:
> Be open. We invite anyone to participate in our community. **We preferably use public methods of communication for project-related messages, unless discussing something sensitive.** This applies to messages for help or project-related support, too; not only is a public support request much more likely to result in an answer to a question, it also makes sure that any inadvertent mistakes made by people answering will be more easily detected and corrected.
(own bold - pogrubienie własne)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-645547625
Thanks for opening your first issue here! Be sure to follow the issue template!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-645586691
devel or develop gets my vote as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647555792
Oh ace - If you delete a branch after merging it, GitHub no longer closes PRs that were based on that branch. This helps with renaming 'master', but also helps generally with PRs that are branches of branches. https://github.blog/changelog/2020-05-19-pull-request-retargeting/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-661714332
https://github.com/github/renaming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on issue #9351: Consider renaming master branch to something less offensive
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #9351:
URL: https://github.com/apache/airflow/issues/9351#issuecomment-647542295
Agree. While I am all for changing - I think we can wreak havoc by haste changes here.
An Idea: Why don't we continue working on 2.0 in master and once we start 2.1 work we can create "development" branch and rather than switching to master immediately we will simply ask everyone to move their PR to "development" for their PRs if they want to get them merged. This way we can do it gradually and naturally. And it's a good opportunity for a "clean" start for 2.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org