[GitHub] [hive] pvary commented on a diff in pull request #3259: HIVE-26190: Implement create iceberg table with metadata location

[GitBox <gi...@apache.org>]

pvary commented on code in PR #3259:
URL: https://github.com/apache/hive/pull/3259#discussion_r862637833


##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -100,6 +101,11 @@ public void initialize(String inputName, Map<String, String> properties) {
     this.clients = new CachedClientPool(conf, properties);
   }
 
+  @Override
+  public TableBuilder buildTable(TableIdentifier identifier, Schema schema) {
+    return new HiveCatalog.HiveCatalogTableBuilder(identifier, schema);

Review Comment:
   nit: We can use:
   ```
   return new HiveCatalogTableBuilder(identifier, schema);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org